align tests

aragon · Feb 17, 2025 · a2e12ab · a2e12ab
1 parent 9203a37
commit a2e12ab
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 16 deletions.
diff --git a/src/core/components/tabs/tabsList/tabsList.test.tsx b/src/core/components/tabs/tabsList/tabsList.test.tsx
@@ -1,28 +1,30 @@
 import { render, screen } from '@testing-library/react';
-import type { ReactNode } from 'react';
-import { Tabs } from '../../tabs';
+import { type ITabsListProps, Tabs } from '../../tabs';
 
 describe('<Tabs.List /> component', () => {
-    const createTestComponent = (children: ReactNode) => (
-        <Tabs.Root>
-            <Tabs.List>{children}</Tabs.List>
-        </Tabs.Root>
-    );
+    const createTestComponent = (props: Partial<ITabsListProps>) => {
+        const completeProps: ITabsListProps = { ...props };
+        return (
+            <Tabs.Root>
+                <Tabs.List {...completeProps} />
+            </Tabs.Root>
+        );
+    };
 
     it('should render multiple tab triggers without crashing', () => {
-        render(
-            createTestComponent([
-                <Tabs.Trigger key="1" label="Tab 1" value="1" />,
-                <Tabs.Trigger key="2" label="Tab 2" value="2" />,
-            ]),
-        );
+        const children = [
+            <Tabs.Trigger key="1" label="Tab 1" value="1" />,
+            <Tabs.Trigger key="2" label="Tab 2" value="2" />,
+        ];
+        render(createTestComponent({ children }));
 
         expect(screen.getByText('Tab 1')).toBeInTheDocument();
         expect(screen.getByText('Tab 2')).toBeInTheDocument();
     });
 
     it('should render null when only a single tab trigger is present', () => {
-        render(createTestComponent(<Tabs.Trigger label="Tab 1" value="1" />));
+        const children = <Tabs.Trigger label="Tab 1" value="1" />;
+        render(createTestComponent({ children }));
 
         expect(screen.queryByText('Tab 1')).not.toBeInTheDocument();
     });

diff --git a/src/core/components/tabs/tabsTrigger/tabsTrigger.test.tsx b/src/core/components/tabs/tabsTrigger/tabsTrigger.test.tsx
@@ -22,7 +22,7 @@ describe('<Tabs.Trigger /> component', () => {
 
     it('renders a tab', () => {
         render(createTestComponent());
-        const tab = screen.getByRole('tab', { name: 'Tab 1' });
+        const tab = screen.getByRole('tab');
         expect(tab).toBeInTheDocument();
         expect(tab.getAttribute('disabled')).toBeNull();
     });
@@ -35,7 +35,7 @@ describe('<Tabs.Trigger /> component', () => {
 
     it('disables the tab when the disabled property is set to true', () => {
         render(createTestComponent({ disabled: true }));
-        const tab = screen.getByRole('tab', { name: 'Tab 1' });
+        const tab = screen.getByRole('tab');
         expect(tab.getAttribute('disabled')).toEqual('');
     });
 });