Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3882): Use correct native token symbol for asset transfer warning #403

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Feb 10, 2025

Description

Uses the config for supported chains to fetch correct token symbol when warning users about native transfers in a proposal action.

image

Task: APP-3882

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@thekidnamedkd thekidnamedkd changed the title WIP fix(APP-3882): Use correct native token symbol for asset transfer warning fix(APP-3882): Use correct native token symbol for asset transfer warning Feb 10, 2025
@cgero-eth cgero-eth merged commit 48d1a41 into main Feb 11, 2025
4 checks passed
@cgero-eth cgero-eth deleted the fix/APP-3882 branch February 11, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants