Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3977): Fix cancel button type of InputFileAvatar component #409

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Feb 19, 2025

Description

  • Set cancel button type to "button" to avoid form submit event

Task: APP-3977

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@cgero-eth cgero-eth requested a review from a team February 19, 2025 13:55
@cgero-eth cgero-eth force-pushed the fix-input-file-avatar branch from 4c0e79d to 358f895 Compare February 21, 2025 08:59
@cgero-eth cgero-eth merged commit bd9440b into main Feb 21, 2025
4 checks passed
@cgero-eth cgero-eth deleted the fix-input-file-avatar branch February 21, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant