Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add IPFS api key env variable #419

Closed
wants to merge 1 commit into from
Closed

Feature: Add IPFS api key env variable #419

wants to merge 1 commit into from

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Jun 21, 2023 •
edited by jira bot
Loading

Description

Add env variable for IPFS X-API-KEY header

Task: OS-533

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

heueristik
heueristik approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the OSx repo is for us and not for others to develop with, this change seems adequate.

In other scenarios (plugins, templates), we should provide a (rate-limited?) default key as a fallback so that developers cloning and running the tests don't experience failing deployment tests because of the missing key.

@Rekard0 Rekard0 closed this Feb 14, 2024
@Rekard0 Rekard0 deleted the f/OS-533-ipfs-api-key-env branch February 14, 2024 14:59
@Rekard0
Copy link
Contributor

Rekard0 commented Feb 14, 2024

Closed for the PR being out of date,
We will address this issue in the future when it comes up again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @Rekard0 @heueristik