Skip to content

Jira 804 BLE Characteristic initialization issue, git 366 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2017
Merged

Jira 804 BLE Characteristic initialization issue, git 366 #433

merged 1 commit into from
Feb 22, 2017

Conversation

SidLeung
Copy link
Contributor

@SidLeung SidLeung commented Feb 8, 2017

Issue:

  • Created Characteristic failed to reflect the initialized
    value.

Root cause:

  • During initialization, the length field was incorrectly
    skipped over.

@SidLeung SidLeung self-assigned this Feb 8, 2017
@SidLeung
Copy link
Contributor Author

SidLeung commented Feb 8, 2017

@bigdinotech @eriknyquist , please review the code.

@noelpaz @russmcinnis , please perform system testing. Please refer to the example presented by Sandeep in the github issue.

@sgbihu , thank you for the resolution.

@SidLeung SidLeung mentioned this pull request Feb 8, 2017
Closed
@SidLeung
Copy link
Contributor Author

@noelpaz , @russmcinnis , awaiting your approval to merge and close this PR.

@kitsunami kitsunami added this to the Deneb milestone Feb 21, 2017
@sgbihu @SidLeung
Jira 804 BLE Characteristic initialization issue, git 366
f610914 
Issue:
-  Created Characteristic failed to reflect the initialized
   value.

Root cause:
-  During initialization, the length field was incorrectly
   skipped over.
@SidLeung
Copy link
Contributor Author

@yashaswini-hanji , please merge this PR to main and close out the Jira 804 upon completion.

@ndgbuilder ndgbuilder merged commit f610914 into arduino:master Feb 22, 2017
@yashaswini-hanji
Copy link
Contributor

Changes merged to base branch.

@kitsunami kitsunami mentioned this pull request Feb 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknyquist eriknyquist eriknyquist approved these changes

@bigdinotech bigdinotech Awaiting requested review from bigdinotech

@russmcinnis russmcinnis Awaiting requested review from russmcinnis

@noelpaz noelpaz Awaiting requested review from noelpaz

Assignees
No one assigned
Labels
Under Review
Projects
None yet
Milestone
Deneb
Development

Successfully merging this pull request may close these issues.
6 participants
@SidLeung @yashaswini-hanji @eriknyquist @ndgbuilder @kitsunami @sgbihu