[CHANGE] Remove test key from repository

Author: DarthMike

.github/workflows/CI.yml

@@ -14,8 +14,12 @@ jobs:
   macos:
     needs: lint
     runs-on: macos-latest
+    env:
+      TESTS_PRIVATEKEY: ${{ secrets.TESTS_PRIVATEKEY }}
     steps:
     - uses: actions/checkout@v3
+    - name: SetupKey
+      run: ./scripts/setupKey.sh "${{ secrets.TESTS_PRIVATEKEY }}"
     - name: Build
       run: swift build -v
     - name: Tests
@@ -25,8 +29,12 @@ jobs:
     runs-on: ubuntu-latest
     container:
       image: swift:5.5-bionic
+    env:
+      TESTS_PRIVATEKEY: ${{ secrets.TESTS_PRIVATEKEY }}
     steps:
     - uses: actions/checkout@v3
+    - name: SetupKey
+      run: ./scripts/setupKey.sh "${{ secrets.TESTS_PRIVATEKEY }}"
     - name: Build
       run: swift build -v
     - name: Tests

.gitignore

@@ -66,3 +66,4 @@ fastlane/screenshots
 fastlane/test_output
 
 scripts/bin/*
+TestConfig_private.swift

README.md

@@ -159,7 +159,9 @@ We support querying ERC721 token data via the `ERC721` struct. Including:
 
 ### Running Tests
 
-The tests will all pass when running against Goerli. You will need to provide a URL for the blockchain proxy (e.g. on Infura), and a key-pair in `TestConfig.swift`. Some of the account signing tests will fail, given the signature assertions are against a specific (unprovided) key.
+Some of the tests require a private key, which is not stored in the repository. You can ignore these while testing locally, as CI will use the encrypted secret key from Github.
+
+It's better to run only the tests you need, instead of the whole test suite while developing. If you ever need to set up the key locally, take a look at `TestConfig.swift` where you can manually set it up. Alternatively you can set it up by calling the script `setupKey.sh` and passing the value (adding 0x) so it's written to an ignored file.
 
 ## Dependencies
 

scripts/setupKey.sh

@@ -0,0 +1,4 @@
+#!/bin/sh
+
+# write first argument to a Test
+echo "extension TestConfig {\nstatic let privateKey = \"$1\"\n}" > web3sTests/TestConfig_private.swift

web3sTests/TestConfig.swift

@@ -13,11 +13,11 @@ struct TestConfig {
     // This is the proxy wss URL for connecting to the Blockchain. For testing we usually use the Goerli network on Infura. Using free tier, so might hit rate limits
     static let wssUrl = "wss://goerli.infura.io/ws/v3/b2f4b3f635d8425c96854c3d28ba6bb0"
 
-    // An EOA with some Ether, so that we can test sending transactions (pay for gas)
-    static let privateKey = "0xef4e182ae2cf32192d2a62c1159c8c4f7f2d658c303d0dfca5791a205456a132"
+    // An EOA with some Ether, so that we can test sending transactions (pay for gas). Set by CI
+//    static let privateKey = "SET_YOUR_KEY_HERE"
 
     // This is the expected public key (address) from the above private key
-    static let publicKey = "0x719561fee351F7aC6560D0302aE415FfBEEc0B51"
+    static let publicKey = "0xE78e5ecb061fE3DD1672dDDA7b5116213B23B99A"
 
     // A test ERC20 token contract (UNI)
     static let erc20Contract = "0x1f9840a85d5aF5bf1D1762F925BDADdC4201F984"