Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 and Dependency issues (Thor) #194

Open
joshm1204 opened this issue Dec 27, 2019 · 5 comments
Open

Rails 6 and Dependency issues (Thor) #194

joshm1204 opened this issue Dec 27, 2019 · 5 comments

Comments

@joshm1204
Copy link

Trying to upgrade to rails 6 and got the below error.


rails (~> 6.0, >= 6.0.2.1) was resolved to 6.0.2.1, which depends on
      railties (= 6.0.2.1) was resolved to 6.0.2.1, which depends on
        thor (>= 0.20.3, < 2.0)

    select2-rails was resolved to 4.0.3, which depends on
      thor (~> 0.14)

I assume select2-rails needs to update it's dependency requirements to make it compatible with rails 6.

@williamweckl
Copy link

I think you just have to update thor. Thor version 0.20.3 is compatible with 0.14. I know because we have thor version 0.20.3 installed and select2-rails.

Update your thor library:
bundle update thor

@seb-sykio
Copy link

still it would be wonderful to have an update with thor 1.0.1

@williamweckl
Copy link

@seb-sykio Would be perfect! Looking forward for the result of this thread: #193 (comment)

@Vasfed
Copy link

Vasfed commented Feb 4, 2020

Thor is only used for rake update-select2 task that is used to update select2 code from upstream (also renames i18n files), I think it should be a development dependency, or at least optional

@OpenCoderX
Copy link
Collaborator

@Vasfed You are correct, for this gem thor is just for development. There is also a rake task that will update the select2 dependencies. Anyhow, select2-rails now requires thor ~> 1 hopefully that resolves this issue.

@joshm1204 Can you test this with your rails 6 app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants