Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repo-server): When using custom kustomize versions, obtain the correct path (#21449) #21537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(repo-server): When using custom kustomize versions, obtain the correct path (#21449) #21537

wants to merge 1 commit into from
+24 −14

Conversation

Asuforce
Copy link
Contributor

Fixes #21449

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@Asuforce Asuforce requested a review from a team as a code owner January 17, 2025 07:16
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Jan 17, 2025 •
edited
Loading

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-yiuzeh.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-yiuzeh.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@Asuforce Asuforce force-pushed the bugfix/helm-option-with-kustomize branch from c489fed to 4584f4f Compare January 17, 2025 07:30
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.29%. Comparing base (37a7231) to head (4584f4f).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
util/kustomize/kustomize.go 76.92% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21537      +/-   ##
==========================================
+ Coverage   52.98%   55.29%   +2.31%     
==========================================
  Files         337      337              
  Lines       56836    56826      -10     
==========================================
+ Hits        30114    31422    +1308     
+ Misses      24079    22723    -1356     
- Partials     2643     2681      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev changed the title fix: When using custom kustomize versions, obtain the correct path #21449 fix(repo-server): When using custom kustomize versions, obtain the correct path (#21449) Jan 17, 2025
@nitishfy nitishfy self-assigned this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nitishfy nitishfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with Kustomize with --enable-helm option
2 participants
@Asuforce @nitishfy