Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement additional crossplane resource health checks #21479

Open
jan-mrm opened this issue Jan 13, 2025 · 2 comments
Open

Implement additional crossplane resource health checks #21479

jan-mrm opened this issue Jan 13, 2025 · 2 comments
Labels

Comments

@jan-mrm
Copy link

jan-mrm commented Jan 13, 2025

Summary

Add additional custom resource health checks for crossplane resources such as:

  • pkg.crossplane.io/
    • Configuration
    • ConfigurationRevision
    • ProviderRevision
    • Function
  • apiextensions.crossplane.io/
    • CompositeResourceDefinition
    • Composition
    • CompositionRevision

Motivation

Currently only pkg.crossplane.io/Provider is implemented within the ArgoCD resource_customizations

I feel like resource health checks are very helpful and I'd like expand them to the above resources / or a subset of them / or also others depending on feedback.

Proposal

I guess this seems somewhat straight forward by looking into the resources and adding checks with tests for each resource as described in the argo docs


Are there any guidelines about when its ok to add a check here into the ArgoCD project repo?
Are there any concerns about the number of checks to be considered?

@jan-mrm jan-mrm added the enhancement New feature or request label Jan 13, 2025
@crenshaw-dev
Copy link
Member

Are there any guidelines about when its ok to add a check here into the ArgoCD project repo?

Not really. I'd say if it's a publicly-available CRD, it's definitely up for acceptance. Crossplane health checks would definitely be welcomed.

Are there any concerns about the number of checks to be considered?

Nope! The more the merrier.

@jan-mrm
Copy link
Author

jan-mrm commented Jan 14, 2025

Cool, then I will see what I can do and start with some resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants