Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argocd-cli app diff validation not working with multi-source application #21527

Open
3 tasks done
asifasido opened this issue Jan 16, 2025 · 0 comments
Open
3 tasks done
Labels
bug Something isn't working component:cli Affects the Argo CD CLI component:multi-source-apps version:2.13 Latest confirmed affected version is 2.13

Comments

@asifasido
Copy link

asifasido commented Jan 16, 2025

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug
When trying to validate changes in a multi-source application using argocd app diff or argocd app sync, Argo CD did not return any errors for invalid YAML files or other issues. It seems this functionality is not supported multi-source application.
The branch I provided for revision contains changes, but Argo CD did not notify about any changes.
To Reproduce

  1. Create an ArgoCD application with multiple sources (for example, a Helm chart and a values file from a different repo)
  2. Try to compare changes using different revisions for different sources:
argocd app sync <app-name> \
  --revisions <chart-version> --source-positions 1 \
  --revisions <pr-branch> --source-positions 2 \
  --dry-run \
  --preview-changes \
  --grpc-web

Expected behavior
I'm trying to use the following command to validate PRs before merging them to the main branch
When using with multiple sources and different revisions, I expect the command to perform thorough validation of the changes, similar to how Kubernetes admission controllers work. Specifically:

  1. The command should validate the rendered manifests before reporting success
  2. If a values.yaml file contains changes that would break the application (like missing quotes ' schedule: * */12 * * *
    ' , invalid configuration), the dry-run should fail

Screenshots

Image

Image

Version

Image

@asifasido asifasido added the bug Something isn't working label Jan 16, 2025
@asifasido asifasido changed the title Validation in multi-source application Argocd-cli app diff validation not working with multi-source application Jan 16, 2025
@agaudreault agaudreault added component:cli Affects the Argo CD CLI component:multi-source-apps version:2.13 Latest confirmed affected version is 2.13 labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:cli Affects the Argo CD CLI component:multi-source-apps version:2.13 Latest confirmed affected version is 2.13
Projects
None yet
Development

No branches or pull requests

2 participants