Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow External Spec/Template References within the Rollouts Experiment Specification #374

Open
tomsanbear opened this issue Jan 22, 2020 · 1 comment
Labels
enhancement New feature or request experiment Related to Experiment CRD

Comments

@tomsanbear
Copy link
Contributor

Summary:
Currently, within a standalone argo-rollouts experiment, one has to write out the entire pod template for running experiments. It would be nice to reference existing/externally existing pod templates/deployments instead to allow for flexibility when using the experiments API.

Sample Potential Spec (from: @jessesuen )

kind: Experiment
apiVersion: argoproj.io/v1alpha1
metadata:
  name: my-experiment
spec:
  templates:
  - name: foo
    specRef:
      kind: Deployment
      apiVersion: apps/v1
      name: my-deployment

Motivation:
I would like to use the experiments spec, and not the rollouts spec for testing deployments in my ArgoCD environments, but do not want to manage the pod specs in multiple places.

Points of Interest:
Some initial concerns/thoughts with this after chatting with @jessesuen

  • What will happen when the referenced spec is deleted or modified
  • What restrictions need to be made
  • What options are required when selecting/referencing a template to ensure uniqueness

(Original Conversation on slack)

@jessesuen jessesuen added enhancement New feature or request experiment Related to Experiment CRD labels Jan 25, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

This issue is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experiment Related to Experiment CRD
Projects
None yet
Development

No branches or pull requests

2 participants