Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): consistent actor email label. Fixes #14121 #14122

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Jan 24, 2025

Fixes #14121

Motivation

make actor email label consistent, align with creator email label

Modifications

UserActionLabel function in workflow/creator/creator.go is missing Email specific string modification
This function is used in patchShutdownStrategy

Verification

Added unit test -> test failed
Added code change -> test succeeded

Signed-off-by: Tianchu Zhao <[email protected]>
tczhao added a commit to tczhao/argo that referenced this pull request Jan 24, 2025
@tczhao tczhao requested a review from isubasinghe January 24, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The workflows.argoproj.io/actor-email is different between stop and resume workflow
2 participants