feat: Enable SkipDryRunOnMissingResource sync option on Application level (#712)

* fix: go mod tidy is not working due to k8s.io/externaljwt dependency

Signed-off-by: pasha <[email protected]>

* feat: Enable SkipDryRunOnMissingResource sync option on Application level

Signed-off-by: pasha <[email protected]>

* feat: Enable SkipDryRunOnMissingResource sync option on Application level

* feat: add support for skipping dry run on missing resources in sync context

- Introduced a new option to skip dry run verification for missing resources at the application level.
- Updated the sync context to include a flag for this feature.
- Enhanced tests to cover scenarios where the skip dry run annotation is applied to all resources.

---------

Signed-off-by: pasha <[email protected]>
Co-authored-by: pasha <[email protected]>

Author: pasha-codefresh

pkg/sync/sync_context.go

@@ -194,6 +194,12 @@ func WithSkipDryRun(skipDryRun bool) SyncOpt {
 	}
 }
 
+func WithSkipDryRunOnMissingResource(skipDryRunOnMissingResource bool) SyncOpt {
+	return func(ctx *syncContext) {
+		ctx.skipDryRunOnMissingResource = skipDryRunOnMissingResource
+	}
+}
+
 func WithServerSideApply(serverSideApply bool) SyncOpt {
 	return func(ctx *syncContext) {
 		ctx.serverSideApply = serverSideApply
@@ -340,19 +346,20 @@ type syncContext struct {
 	resourceOps         kubeutil.ResourceOperations
 	namespace           string
 
-	dryRun                 bool
-	skipDryRun             bool
-	force                  bool
-	validate               bool
-	skipHooks              bool
-	resourcesFilter        func(key kubeutil.ResourceKey, target *unstructured.Unstructured, live *unstructured.Unstructured) bool
-	prune                  bool
-	replace                bool
-	serverSideApply        bool
-	serverSideApplyManager string
-	pruneLast              bool
-	prunePropagationPolicy *metav1.DeletionPropagation
-	pruneConfirmed         bool
+	dryRun                      bool
+	skipDryRun                  bool
+	skipDryRunOnMissingResource bool
+	force                       bool
+	validate                    bool
+	skipHooks                   bool
+	resourcesFilter             func(key kubeutil.ResourceKey, target *unstructured.Unstructured, live *unstructured.Unstructured) bool
+	prune                       bool
+	replace                     bool
+	serverSideApply             bool
+	serverSideApplyManager      string
+	pruneLast                   bool
+	prunePropagationPolicy      *metav1.DeletionPropagation
+	pruneConfirmed              bool
 
 	syncRes   map[string]common.ResourceSyncResult
 	startedAt time.Time
@@ -818,11 +825,18 @@ func (sc *syncContext) getSyncTasks() (_ syncTasks, successful bool) {
 			}
 		}
 
+		shouldSkipDryRunOnMissingResource := func() bool {
+			// skip dry run on missing resource error for all application resources
+			if sc.skipDryRunOnMissingResource {
+				return true
+			}
+			return (task.targetObj != nil && resourceutil.HasAnnotationOption(task.targetObj, common.AnnotationSyncOptions, common.SyncOptionSkipDryRunOnMissingResource)) ||
+				sc.hasCRDOfGroupKind(task.group(), task.kind())
+		}
+
 		if err != nil {
 			switch {
-			case apierrors.IsNotFound(err) &&
-				((task.targetObj != nil && resourceutil.HasAnnotationOption(task.targetObj, common.AnnotationSyncOptions, common.SyncOptionSkipDryRunOnMissingResource)) ||
-					sc.hasCRDOfGroupKind(task.group(), task.kind())):
+			case apierrors.IsNotFound(err) && shouldSkipDryRunOnMissingResource():
 				// Special case for custom resources: if CRD is not yet known by the K8s API server,
 				// and the CRD is part of this sync or the resource is annotated with SkipDryRunOnMissingResource=true,
 				// then skip verification during `kubectl apply --dry-run` since we expect the CRD

pkg/sync/sync_context_test.go

@@ -148,9 +148,10 @@ func TestSyncCreateInSortedOrder(t *testing.T) {
 
 func TestSyncCustomResources(t *testing.T) {
 	type fields struct {
-		skipDryRunAnnotationPresent bool
-		crdAlreadyPresent           bool
-		crdInSameSync               bool
+		skipDryRunAnnotationPresent                bool
+		skipDryRunAnnotationPresentForAllResources bool
+		crdAlreadyPresent                          bool
+		crdInSameSync                              bool
 	}
 
 	tests := []struct {
@@ -174,6 +175,9 @@ func TestSyncCustomResources(t *testing.T) {
 		{"unknown crd, skip dry run annotated", fields{
 			skipDryRunAnnotationPresent: true, crdAlreadyPresent: false, crdInSameSync: false,
 		}, false, true},
+		{"unknown crd, skip dry run annotated on app level", fields{
+			skipDryRunAnnotationPresentForAllResources: true, crdAlreadyPresent: false, crdInSameSync: false,
+		}, false, true},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -211,6 +215,10 @@ func TestSyncCustomResources(t *testing.T) {
 				cr.SetAnnotations(map[string]string{synccommon.AnnotationSyncOptions: "SkipDryRunOnMissingResource=true"})
 			}
 
+			if tt.fields.skipDryRunAnnotationPresentForAllResources {
+				syncCtx.skipDryRunOnMissingResource = true
+			}
+
 			resources := []*unstructured.Unstructured{cr}
 			if tt.fields.crdInSameSync {
 				resources = append(resources, testingutils.NewCRD())
@@ -2151,6 +2159,7 @@ func BenchmarkSync(b *testing.B) {
 	maxContainers := 10
 	for i := 0; i < b.N; i++ {
 		b.StopTimer()
+
 		containerCount := min(i+1, maxContainers)
 
 		containerStr := strings.Repeat(container+",", containerCount)