-
Notifications
You must be signed in to change notification settings - Fork 340
Handle standard JSON translation with outputSelection for =<0.4.19 #690
Copy link
Copy link
Open
Labels
low effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.should haveWe like the idea but it’s not important enough to be a part of the roadmap.We like the idea but it’s not important enough to be a part of the roadmap.
Metadata
Metadata
Assignees
Labels
low effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.should haveWe like the idea but it’s not important enough to be a part of the roadmap.We like the idea but it’s not important enough to be a part of the roadmap.
We've come across an issue while recompiling a contract with
0.4.19as laid out here: argotorg/sourcify#1017TLDR: The compiler gives empty JSON output without throwing because the
outputSelectionfields were introduced in0.4.18and updated in0.4.19.I believe the
outputSelectionfield needs to be handled by the JSON translator translate.ts ofsolc-jsfor the earlier versions.