Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arrow key navigation in Tabs #112

Open
argyleink opened this issue Apr 20, 2022 · 5 comments
Open

Support arrow key navigation in Tabs #112

argyleink opened this issue Apr 20, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@argyleink
Copy link
Owner

focus on the nav of links and if the arrows are used, shift between the tabs.
could also add roving-ux so state is saved?

shoutout to Rob Levin for the idea

@argyleink argyleink added the enhancement New feature or request label Apr 20, 2022
@roblevintennis
Copy link

Nice @argyleink -- I also noticed on the modal demo tabs aren't trapped. Not sure if that's something else you're interested in. I have too much work on the AgnosticUI stuff at the moment so unfortunately can't lend a helping hand :(

@argyleink
Copy link
Owner Author

Nice @argyleink -- I also noticed on the modal demo tabs aren't trapped. Not sure if that's something else you're interested in. I have too much work on the AgnosticUI stuff at the moment so unfortunately can't lend a helping hand :(

yeah, no focus trapping, just inert, like how window.alert() works. that'd be a nice remix idea tho! sharing "your style" and the things you find important 🙂

@roblevintennis
Copy link

I'm implemented svelte-a11y-dialog and angular-a11y-dialog and ported Vue-a11y-dialog to Vue 3 (and then delegated to those from AgnosticUI) but those don't use native dialog for the issues documented by a11y-dialog 🤓🙂

@argyleink argyleink changed the title Support array key navigation in Tabs Support arrow key navigation in Tabs Jul 25, 2022
@btwshivam
Copy link

hey, I want to work on it. assign me!

@argyleink
Copy link
Owner Author

hey, I want to work on it. assign me!

sweet! you got it!

@btwshivam btwshivam removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants