Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit code before end of 2018 #354

Open
Cliabhach opened this issue Nov 27, 2018 · 0 comments
Open

Audit code before end of 2018 #354

Cliabhach opened this issue Nov 27, 2018 · 0 comments
Assignees

Comments

@Cliabhach
Copy link
Contributor

This codebase has changed a lot since the first commit. @sam33rdhakal and myself will undertake a basic audit, looking for the following things:

  • Code we don't understand
  • Duplicated code
  • Unused code
  • Over-complicated code

We'll create PRs for these as we see them, and link them back to this issue. Note that we are not looking to make any significant changes to business logic; if they do get proposed, such changes will be highlighted.

You can follow along with our progress in the branch code_audit; I'm adding comments and questions in the branch pc-identify-codebase-problems-2018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants