Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownTextView does not always function correctly #359

Open
Cliabhach opened this issue Feb 12, 2019 · 0 comments
Open

DropdownTextView does not always function correctly #359

Cliabhach opened this issue Feb 12, 2019 · 0 comments
Assignees

Comments

@Cliabhach
Copy link
Contributor

This corresponds to the problems we saw in #358 and #357 , under ticket AIC-646.

Put simply, if we define

<edu.artic.view.DropdownTextView
    android:id="@+id/whatever"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:visibility="gone"
    />

then RxJava2 calls such as this one sometimes fail to trigger. While we have not been able to calculate a precise incidence rate the Samsung Galaxy S8+ is particularly susceptible. Our current logic inverts the logic (that is, show the views by default and only hide them if derived text is empty), and this seems to work.

@agrosner do you have any thoughts? Perhaps the show binding is being set up too late or disposed of too early?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants