Skip to content

Commit 5bba3d3

Browse files
author
Arthur Douillard
committed
[common] Add more training information.
1 parent ea60845 commit 5bba3d3

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

inclearn/lib/results_utils.py

+6-11
Original file line numberDiff line numberDiff line change
@@ -48,29 +48,24 @@ def extract(paths, avg_inc=False):
4848
raise NotImplementedError(type(data["results"][0]))
4949

5050
if avg_inc:
51-
accs = compute_avg_inc_acc(accs)
51+
raise NotImplementedError("Deprecated")
5252

5353
runs_accs.append(accs)
5454

5555
return runs_accs
5656

5757

58-
def compute_avg_inc_acc(accs):
58+
def compute_avg_inc_acc(results):
5959
"""Computes the average incremental accuracy as defined in iCaRL.
6060
6161
The average incremental accuracies at task X are the average of accuracies
6262
at task 0, 1, ..., and X.
6363
64-
:param accs: A list of accuracies.
65-
:return: A list of average incremental accuracies.
64+
:param accs: A list of dict for per-class accuracy at each step.
65+
:return: A float.
6666
"""
67-
avg_inc_accs = []
68-
69-
for i in range(len(accs)):
70-
sub_accs = [accs[j] for j in range(0, i + 1)]
71-
avg_inc_accs.append(sum(sub_accs) / len(sub_accs))
72-
73-
return avg_inc_accs
67+
tasks_accuracy = [r["total"] for r in results]
68+
return sum(tasks_accuracy) / len(tasks_accuracy)
7469

7570

7671
def aggregate(runs_accs):

inclearn/train.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def train(args):
1818

1919
start_time = time.time()
2020
_train(args)
21-
print("Training finished in {}s.".format(time.time() - start_time))
21+
print("Training finished in {}s.".format(int(time.time() - start_time)))
2222

2323

2424
def _train(args):
@@ -65,6 +65,12 @@ def _train(args):
6565

6666
memory = model.get_memory()
6767

68+
print(
69+
"Average Incremental Accuracy: {}.".format(
70+
results_utils.compute_avg_inc_acc(results["results"])
71+
)
72+
)
73+
6874
if args["name"]:
6975
results_utils.save_results(results, args["name"])
7076

0 commit comments

Comments
 (0)