Skip to content

Restrict faraday upper version range #126

@shawnHartsell

Description

@shawnHartsell

Similar to #124

The current version range of faraday is set to < 3. This caused an error in our Twirp API CI/CD pipelines due to (what appears) to be a breaking change that was introduced between versions 2.11.0 and 2.12.0 of faraday (released today).

Specifically, it appears to be around an explicit json dependency added in 2.12.0 of the Gem. 2.12.0 release notes. We resolved the issue by explicitly requiring 2.11.0 of Faraday in our tooling.

I'm not intimately familiar in faraday's release process, so I can't speak to if introducing breaking changes in minor versions is normal for that lib. However, I think it would be good if we could protect consumers of twirp Ruby by being a bit more restrictive on the upper bound of the version range.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions