Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom ca for self signed certs #199

Open
mrchief opened this issue Nov 2, 2016 · 2 comments
Open

Support custom ca for self signed certs #199

mrchief opened this issue Nov 2, 2016 · 2 comments
Labels
enhancement

Comments

@mrchief
Copy link
Contributor

mrchief commented Nov 2, 2016 •
edited
Loading

In addition to -k or

tls: 
  rejectUnauthorized: false

options which completely disable ssl verify, it'd be nice to have an option to pass custom ca. Something like:

tls: 
  ca: './ca.crt'
@hassy
Copy link
Member

hassy commented Nov 9, 2016

Anything set in config.tls will be merged into the Request options:

https://github.com/request/request#tlsssl-protocol

@mrchief
Copy link
Contributor Author

mrchief commented Nov 9, 2016

Yes but that leaves the file reading bit to the user. Not a huge pain but now its not just a simple yaml/json config file.

hassy added a commit that referenced this issue Apr 27, 2018
@hassy
Merge pull request #199 from hassy/http-agent
13ca26c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hassy @mrchief