Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatching playwright versions stopping tasks from running #3423

Closed
sam-barker opened this issue Dec 2, 2024 · 6 comments
Closed

Mismatching playwright versions stopping tasks from running #3423

sam-barker opened this issue Dec 2, 2024 · 6 comments

Comments

@sam-barker
Copy link

Version info:

2.0.21

Running this command:

      artillery run-fargate \
          --region eu-west-1 \
          --dotenv ./.env \
          --cpu $CPU \
          --memory $MEM \
          --max-duration $MAX_DURATION \
          --count $TASK_COUNT \
          --cluster $CLUSTER_NAME \
          --subnet-ids $(aws ssm get-parameter --name /VpcConfig/SubnetIds --region $REGION --output text --query Parameter.Value) \
          --security-group-ids $(aws ssm get-parameter --name /VpcConfig/SecurityGroupIds --region $REGION --output text --query Parameter.Value) \
          ${CONFIG_FILE} \
          --quiet \
          $FLAGS \

I expected to see this happen:

We expected to be able to run the tests as usual

Instead, this happened:

We haven't made any changes or updated any dependencies, but it seems that playwright have published a new version and so it is preventing us from using 1.48.0, even though I have explicitly pinned every version of everything to do with playwright to this version i.e.

  "resolutions": {
    "@playwright/test": "1.48.0",
    "@playwright/browser-chromium": "1.48.0",
    "playwright": "1.48.0",
    "artillery/@playwright/test": "1.48.0",
    "artillery/playwright": "1.48.0",
    "artillery-engine-playwright/@playwright/test": "1.48.0",
    "artillery-engine-playwright/@playwright/browser-chromium": "1.48.0",
    "artillery-engine-playwright/playwright": "1.48.0"
  },
Screenshot 2024-12-02 at 15 28 05

It looks like the docker image is the cause of this. Is there any way around this other than having to wait for a new version of artillery?

@sam-barker
Copy link
Author

sam-barker commented Dec 3, 2024

For some more info: doesn't look like it happens to all the tasks. It just takes one of these to occur and the whole test run stops because of it. Which is even weirder that this isn't happening to all of the tasks.

Also seems to happen on the leader task

@hassy
Copy link
Member

hassy commented Dec 3, 2024

Thanks @sam-barker - this looks like a bug in Artillery - v2.0.21 did not pin to a specific version of Playwright - https://github.com/artilleryio/artillery/blob/main/packages/artillery-engine-playwright/package.json#L23-L24 - so a new patch release can break worker containers

@sam-barker
Copy link
Author

@hassy I have tried downgrading artillery to v2.0.20 and artillery-engine-playwright to v1.17.0 and I still get the same problem

Screenshot 2024-12-03 at 15 06 08

As far as I'm aware this should use artillery 1.45.3, so I'm not sure why it's complaining about 1.48.1?

@hassy
Copy link
Member

hassy commented Dec 3, 2024

Yep, that version of Artillery has an exact pin to v1.45.3. There must be something in the dependency tree that's pulling in a more recent version of Playwright then - what does the table showing all bundled dependencies show when you trigger the test run with run-fargate?

@sam-barker
Copy link
Author

I think we've found it. For some reason we were installing artillery and artillery-engine-playwright and that caused the mismatch. All works with artillery 2.0.20, going to go back to 2.0.21 and see if it's all good

@sam-barker
Copy link
Author

So 2.0.20 works but 2.0.21 does not, so we're going to stick with the previous version until something is released that pins the versions of playwright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants