Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Release doesn't have latest code #71

Open
veris-neerajdhiman opened this issue Sep 8, 2017 · 6 comments
Open

Latest Release doesn't have latest code #71

veris-neerajdhiman opened this issue Sep 8, 2017 · 6 comments

Comments

@veris-neerajdhiman
Copy link

  • I have installed latest Release 1.3.1 but it don't have latest code as you have in your master branch.

e.g.,

  1. Earlier you have _clean_data as separate function but now you have moved it to class function and modified it too. Release 1.3.1 still have old code for this function (I have checked source code of Release too)
  2. The actual error I was getting is TypeError: expected string or bytes-like object in line No 137 if SENSITIVE_DATA.search(key):
  3. So when I checked installed Lib code and Master branch code, It was different.
  4. So please update Release code and also check if New code can fix my original error which is mentioned in 2nd point .
  5. Here data is a list of dict()
[   {
       "actor_type": "tets",
       "meeting_with": "Self",
       "first_name": "qwert",
       "last_name": "asdfg",
       "logged_at": "1448113944"
   }
   ]
@veris-neerajdhiman veris-neerajdhiman changed the title Latest Release not downloading latest code Latest Release doesn't have latest code Sep 8, 2017
@triat
Copy link
Contributor

triat commented Sep 12, 2017

Hello @veris-neerajdhiman, if you want to check if your error is fixed, you can also install the code from master directly with pip.

Let us know if the issue is still there

@veris-neerajdhiman
Copy link
Author

veris-neerajdhiman commented Sep 12, 2017

@triat yes issue was still there so for now I have forked this repo and patched a hot fix (for loop) but you must verify the same at your end and apply permanent fix.

@triat
Copy link
Contributor

triat commented Sep 12, 2017

@veris-neerajdhiman can I propose that you do a PR if you already did the fix ? and write tests maybe ? Much appreciated

@veris-neerajdhiman
Copy link
Author

@triat PR #73 created for this issue, Please check

@avelis
Copy link
Collaborator

avelis commented Sep 22, 2017

@veris-neerajdhiman @triat
I think the critical issue here that we are attempting force a dict copy on a post body that might not always translate to a dict. In that scenario we could consider using the polymorphic copy.deepcopy and make _clean_data be able to handle a list of dictionaries or just ignore cleaning a list structure.

Thoughts?

@veris-neerajdhiman
Copy link
Author

@avelis

  • I have used copy.deepcopy() you can check in my commits.
  • Secondly I think we should not ignore list structure as it may or may not include sensitive data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants