Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to phantomjs 2.x / grunt-lib-phantomjs 1.1.0 #58

Open
DerZyklop opened this issue Jun 1, 2016 · 1 comment
Open

Upgrade to phantomjs 2.x / grunt-lib-phantomjs 1.1.0 #58

DerZyklop opened this issue Jun 1, 2016 · 1 comment

Comments

@DerZyklop
Copy link

This plugin uses PhantomJS 1.9.x.

This causes problems in my environment. I don‘t understand much about how this plugin works, but i couldn‘t see a good reason not to use grunt-lib-phantomjs 1.1.0 instead of grunt-lib-phantomjs-istambul. I replaced

"grunt-lib-phantomjs-istanbul": "~0.6.0"

with

"grunt-lib-phantomjs": "~1.0.0",

in package.json

and

var phantomjs = require('grunt-lib-phantomjs-istanbul').init(grunt);

with

var phantomjs = require('grunt-lib-phantomjs').init(grunt);

in qunit.js and now grunt-qunit-istanbul is working fine for me (shows coverage in Terminal).

If there isn‘t a good reason to use PhantomJS 1.9.x i suggest to update it to 2.x.

Thanks for this plugin, mate! ✌

@DerZyklop
Copy link
Author

Uups.. i was wrong. It‘s still not working correctly. It doesn‘t find the js files and shows 100% coverage of 0 files. Not sure it this is caused by my modifications or not.

However.. the »clean« verion of grunt-qunit-istanbul isn't working for me, because of the mentioned "Negative Cache"-problem of PhantomJS 1.9.x. If anyone has an idea how to solve this, i‘m happy to hear from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant