Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice message about 0.16.0 asdf version #587

Open
ArnauLlamas opened this issue Jan 31, 2025 · 7 comments
Open

Notice message about 0.16.0 asdf version #587

ArnauLlamas opened this issue Jan 31, 2025 · 7 comments

Comments

@ArnauLlamas
Copy link

Since the release of asdf version 0.16.0 all pipelines show this message several times:

----------

NOTICE:

You have tried to upgrade to asdf 0.16.0 or newer. Versions 0.16.0 is a
complete rewrite of asdf in Go. This text is being printed by the older
Bash implementation. If you are seeing this you have not migrated to
asdf 0.16.0. Please follow the instructions on the upgrade guide to
migrate to the new version.

Aside from this notice, this older Bash implementation works as it did
in asdf version 0.15.0 and older.

Migration guide: https://asdf-vm.com/guide/upgrading-to-v0-16
asdf website: https://asdf-vm.com/
Source code: https://github.com/asdf-vm/asdf

While I completely understand the reason of this message to appear, I believe I cannot do anything to make it go or fix it. If that is not the case I would love to know a workaround for it 😁

I would also let you know that, although it is clear that this is a notice message and, at least in my case, nothing broke, it makes the output of the workflow/action jobs hard to read, as I use several tools and the message ends up being repeated a lot of times. Also, people who use the output of actions into other actions might get bigger issues.

@palfrey
Copy link

palfrey commented Feb 2, 2025

One workaround is using

        with:
          asdf_branch: v0.15.0

which doesn't appear to be documented, but will used ASDF 0.15.0 instead of whatever the latest is.

@palfrey
Copy link

palfrey commented Feb 2, 2025

#588 fixes the documentation issue

@palfrey
Copy link

palfrey commented Feb 2, 2025

While I completely understand the reason of this message to appear

In <0.16, ASDF could be installed mostly by just a git clone. Now, it's been rewritten in Go and needs a download (or build from source) instead.

@cf-sewe
Copy link

cf-sewe commented Feb 7, 2025

In order to plan the required update on our side properly: Do you already know when you plan to tackle this issue in the asdf GitHub action? Or will we have to stick with ADF 0.15 for now?

@blimmer
Copy link

blimmer commented Feb 10, 2025

I'm setting asdf_branch to 0.15.0 and I'm still getting the warning message.

@ArnauLlamas
Copy link
Author

Hey @palfrey !
Thanks a lot for your suggestion, it worked perfectly for my use case! I actually saw the asdf_branch input but thought it will not work with tags 🤣 Happy to be wrong here 😃

That being said, although my case is solved I feel I shall not close this issue as the standard behavior of the action ends up with the issue specified in here. Although I will happily create a new one if it works better for maintainers!

@ArnauLlamas
Copy link
Author

ArnauLlamas commented Feb 10, 2025

I'm setting asdf_branch to 0.15.0 and I'm still getting the warning message.

@blimmer Make sure you are setting the asdf_branch input to v0.15.0, in your comment the v is missing at least 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants