Skip to content

Commit 41f43b8

Browse files
pks-tgitster
pks-t
authored and
gitster
committed
global: mark code units that generate warnings with -Wsign-compare
Mark code units that generate warnings with `-Wsign-compare`. This allows for a structured approach to get rid of all such warnings over time in a way that can be easily measured. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 709fdce commit 41f43b8

File tree

265 files changed

+439
-2
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

265 files changed

+439
-2
lines changed

‎add-interactive.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
23

34
#include "git-compat-util.h"
45
#include "add-interactive.h"

‎add-patch.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
23

34
#include "git-compat-util.h"
45
#include "add-interactive.h"

‎advice.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#define DISABLE_SIGN_COMPARE_WARNINGS
2+
13
#include "git-compat-util.h"
24
#include "advice.h"
35
#include "config.h"

‎apply.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
*/
99

1010
#define USE_THE_REPOSITORY_VARIABLE
11+
#define DISABLE_SIGN_COMPARE_WARNINGS
1112

1213
#include "git-compat-util.h"
1314
#include "abspath.h"

‎archive.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
23

34
#include "git-compat-util.h"
45
#include "abspath.h"

‎attr.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
*/
88

99
#define USE_THE_REPOSITORY_VARIABLE
10+
#define DISABLE_SIGN_COMPARE_WARNINGS
1011

1112
#include "git-compat-util.h"
1213
#include "config.h"

‎base85.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#define DISABLE_SIGN_COMPARE_WARNINGS
2+
13
#include "git-compat-util.h"
24
#include "base85.h"
35

‎bisect.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
23

34
#include "git-compat-util.h"
45
#include "config.h"

‎blame.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
23

34
#include "git-compat-util.h"
45
#include "refs.h"

‎bloom.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#define DISABLE_SIGN_COMPARE_WARNINGS
2+
13
#include "git-compat-util.h"
24
#include "bloom.h"
35
#include "diff.h"

‎builtin/add.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
*
44
* Copyright (C) 2006 Linus Torvalds
55
*/
6+
7+
#define DISABLE_SIGN_COMPARE_WARNINGS
8+
69
#include "builtin.h"
710
#include "advice.h"
811
#include "config.h"

‎builtin/am.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
*/
66

77
#define USE_THE_REPOSITORY_VARIABLE
8+
#define DISABLE_SIGN_COMPARE_WARNINGS
9+
810
#include "builtin.h"
911
#include "abspath.h"
1012
#include "advice.h"

‎builtin/bisect.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "copy.h"
46
#include "environment.h"

‎builtin/blame.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
* Copyright (c) 2006, 2014 by its authors
55
* See COPYING for licensing conditions
66
*/
7+
78
#define USE_THE_REPOSITORY_VARIABLE
9+
#define DISABLE_SIGN_COMPARE_WARNINGS
10+
811
#include "builtin.h"
912
#include "config.h"
1013
#include "color.h"

‎builtin/branch.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
* Copyright (c) 2006 Kristian Høgsberg <[email protected]>
55
* Based on git-branch.sh by Junio C Hamano.
66
*/
7+
78
#define USE_THE_REPOSITORY_VARIABLE
9+
#define DISABLE_SIGN_COMPARE_WARNINGS
10+
811
#include "builtin.h"
912
#include "config.h"
1013
#include "color.h"

‎builtin/cat-file.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
*
44
* Copyright (C) Linus Torvalds, 2005
55
*/
6+
67
#define USE_THE_REPOSITORY_VARIABLE
8+
#define DISABLE_SIGN_COMPARE_WARNINGS
9+
710
#include "builtin.h"
811
#include "config.h"
912
#include "convert.h"

‎builtin/checkout--worker.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "config.h"
46
#include "entry.h"

‎builtin/checkout-index.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
* Copyright (C) 2005 Linus Torvalds
55
*
66
*/
7+
78
#define USE_THE_REPOSITORY_VARIABLE
9+
#define DISABLE_SIGN_COMPARE_WARNINGS
10+
811
#include "builtin.h"
912
#include "config.h"
1013
#include "gettext.h"

‎builtin/checkout.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "advice.h"
46
#include "branch.h"

‎builtin/clean.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
*
66
* Based on git-clean.sh by Pavel Roskin
77
*/
8+
89
#define USE_THE_REPOSITORY_VARIABLE
10+
#define DISABLE_SIGN_COMPARE_WARNINGS
11+
912
#include "builtin.h"
1013
#include "abspath.h"
1114
#include "config.h"

‎builtin/clone.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77
*
88
* Clone a repository into a different directory that does not yet exist.
99
*/
10+
1011
#define USE_THE_REPOSITORY_VARIABLE
12+
#define DISABLE_SIGN_COMPARE_WARNINGS
13+
1114
#include "builtin.h"
1215

1316
#include "abspath.h"

‎builtin/commit.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
* Copyright (c) 2007 Kristian Høgsberg <[email protected]>
55
* Based on git-commit.sh by Junio C Hamano and Linus Torvalds
66
*/
7+
78
#define USE_THE_REPOSITORY_VARIABLE
9+
#define DISABLE_SIGN_COMPARE_WARNINGS
10+
811
#include "builtin.h"
912
#include "advice.h"
1013
#include "config.h"

‎builtin/describe.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "config.h"
46
#include "environment.h"

‎builtin/diff-files.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
*
44
* Copyright (C) Linus Torvalds, 2005
55
*/
6+
67
#define USE_THE_REPOSITORY_VARIABLE
8+
#define DISABLE_SIGN_COMPARE_WARNINGS
9+
710
#include "builtin.h"
811
#include "config.h"
912
#include "diff.h"

‎builtin/diff-index.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "config.h"
46
#include "diff.h"

‎builtin/diff-tree.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "config.h"
46
#include "diff.h"

‎builtin/diff.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
*
44
* Copyright (c) 2006 Junio C Hamano
55
*/
6+
67
#define USE_THE_REPOSITORY_VARIABLE
8+
#define DISABLE_SIGN_COMPARE_WARNINGS
9+
710
#include "builtin.h"
811
#include "config.h"
912
#include "ewah/ewok.h"

‎builtin/difftool.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@
1111
*
1212
* Copyright (C) 2016 Johannes Schindelin
1313
*/
14+
1415
#define USE_THE_REPOSITORY_VARIABLE
16+
#define DISABLE_SIGN_COMPARE_WARNINGS
17+
1518
#include "builtin.h"
1619

1720
#include "abspath.h"

‎builtin/fast-export.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
*
44
* Copyright (C) 2007 Johannes E. Schindelin
55
*/
6+
67
#define USE_THE_REPOSITORY_VARIABLE
8+
#define DISABLE_SIGN_COMPARE_WARNINGS
9+
710
#include "builtin.h"
811
#include "config.h"
912
#include "gettext.h"

‎builtin/fast-import.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "abspath.h"
46
#include "environment.h"

‎builtin/fetch-pack.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "gettext.h"
46
#include "hex.h"

‎builtin/fetch.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
/*
22
* "git fetch"
33
*/
4+
45
#define USE_THE_REPOSITORY_VARIABLE
6+
#define DISABLE_SIGN_COMPARE_WARNINGS
7+
58
#include "builtin.h"
69
#include "advice.h"
710
#include "config.h"

‎builtin/for-each-repo.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "config.h"
46
#include "gettext.h"

‎builtin/fsmonitor--daemon.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "abspath.h"
46
#include "config.h"

‎builtin/gc.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@
99
*
1010
* Copyright (c) 2006 Shawn O. Pearce
1111
*/
12+
1213
#define USE_THE_REPOSITORY_VARIABLE
14+
#define DISABLE_SIGN_COMPARE_WARNINGS
15+
1316
#include "builtin.h"
1417
#include "abspath.h"
1518
#include "date.h"

‎builtin/grep.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
*
44
* Copyright (c) 2006 Junio C Hamano
55
*/
6+
67
#define USE_THE_REPOSITORY_VARIABLE
8+
#define DISABLE_SIGN_COMPARE_WARNINGS
9+
710
#include "builtin.h"
811
#include "abspath.h"
912
#include "gettext.h"

‎builtin/help.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
21
/*
32
* Builtin help command
43
*/
4+
55
#define USE_THE_REPOSITORY_VARIABLE
6+
#define DISABLE_SIGN_COMPARE_WARNINGS
7+
68
#include "builtin.h"
79
#include "config.h"
810
#include "exec-cmd.h"

‎builtin/index-pack.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "config.h"
46
#include "delta.h"

‎builtin/log.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
* (C) Copyright 2006 Linus Torvalds
55
* 2006 Junio Hamano
66
*/
7+
78
#define USE_THE_REPOSITORY_VARIABLE
9+
#define DISABLE_SIGN_COMPARE_WARNINGS
10+
811
#include "builtin.h"
912
#include "abspath.h"
1013
#include "config.h"

‎builtin/ls-files.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,10 @@
55
*
66
* Copyright (C) Linus Torvalds, 2005
77
*/
8+
89
#define USE_THE_REPOSITORY_VARIABLE
10+
#define DISABLE_SIGN_COMPARE_WARNINGS
11+
912
#include "builtin.h"
1013
#include "config.h"
1114
#include "convert.h"

‎builtin/mailsplit.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
* It just splits a mbox into a list of files: "0001" "0002" ..
55
* so you can process them further from there.
66
*/
7+
8+
#define DISABLE_SIGN_COMPARE_WARNINGS
9+
710
#include "builtin.h"
811
#include "gettext.h"
912
#include "string-list.h"

‎builtin/merge-file.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "abspath.h"
46
#include "diff.h"

‎builtin/merge-index.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "hex.h"
46
#include "read-cache-ll.h"

‎builtin/merge-ours.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@
77
*
88
* Pretend we resolved the heads, but declare our tree trumps everybody else.
99
*/
10+
1011
#define USE_THE_REPOSITORY_VARIABLE
12+
#define DISABLE_SIGN_COMPARE_WARNINGS
13+
1114
#include "git-compat-util.h"
1215
#include "builtin.h"
1316
#include "diff.h"

‎builtin/merge-tree.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#define USE_THE_REPOSITORY_VARIABLE
2+
#define DISABLE_SIGN_COMPARE_WARNINGS
3+
24
#include "builtin.h"
35
#include "tree-walk.h"
46
#include "xdiff-interface.h"

0 commit comments

Comments
 (0)