AppEngine: handle type casting for longinteger inputs
#969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.1 #969 +/- ##
================================================
- Coverage 81.75% 68.05% -13.71%
================================================
Files 70 281 +211
Lines 1721 7428 +5707
================================================
+ Hits 1407 5055 +3648
- Misses 314 2373 +2059 ☔ View full report in Codecov by Sentry. |
rbino
requested changes
Jul 3, 2024
apps/astarte_appengine_api/lib/astarte_appengine_api/device/device.ex
Outdated
Show resolved
Hide resolved
Hibe7
force-pushed
the
castLongintegerValues
branch
from
32d5af3
to
d8bfac8
Compare
Hibe7
changed the title
longinteger inputslonginteger inputs
Pavinati
approved these changes
Jul 8, 2024
rbino
requested changes
Jul 9, 2024
apps/astarte_appengine_api/lib/astarte_appengine_api/device/device.ex
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/lib/astarte_appengine_api/device/device.ex
Outdated
Show resolved
Hide resolved
Implemented `cast_value/2` functions to support string input parsing for `:longinteger` values and arrays in server-owned interfaces. Signed-off-by: Ismet Softic <[email protected]>
Hibe7
force-pushed
the
castLongintegerValues
branch
from
d8bfac8
to
3d84f4e
Compare
rbino
approved these changes
Jul 9, 2024
rbino
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
cast_value/2functions to support string input parsing forlongintegervalues and arrays in server-owned interfaces. This implementation enables parsing of string inputs into integers where necessary.Fixes #967