Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feature ] Add proxy support for the generate from template command #1621

Open
2 tasks done
AayushSaini101 opened this issue Jan 10, 2025 · 7 comments · May be fixed by #1622
Open
2 tasks done

[ Feature ] Add proxy support for the generate from template command #1621

AayushSaini101 opened this issue Jan 10, 2025 · 7 comments · May be fixed by #1622
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AayushSaini101
Copy link
Collaborator

Why do we need this improvement?

We have already introduced proxy support in multiple commands of cli, reference: #1608 Need to add support in generate command as well.

How will this change help?

we can use the generate command behind the proxy as well.

Screenshots

No response

How could it be implemented/designed?

Reference:https://www.zenrows.com/blog/node-fetch-proxy#how-to-use-proxy-with-node-fetch of the implementation flow of the proxy

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

No, someone else can work on it.

@AayushSaini101 AayushSaini101 added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2025
@github-project-automation github-project-automation bot moved this to To Triage in CLI - Kanban Jan 10, 2025
@IITI-tushar
Copy link

IITI-tushar commented Jan 10, 2025

@AayushSaini101 I want to work on it... Please assign me.

@AayushSaini101
Copy link
Collaborator Author

@AayushSaini101 I want to work on it... Please assign me.

@IITI-tushar sure

@IITI-tushar
Copy link

Thanks, I will open a PR soon.

@cs7-shrey
Copy link

cs7-shrey commented Jan 10, 2025

can I too work on this? @AayushSaini101

@IITI-tushar
Copy link

IITI-tushar commented Jan 10, 2025

@AayushSaini101 in commands/generate folder should i have to add proxy support to all three fromTemplate.ts , index.ts and models.ts files ???

@AayushSaini101
Copy link
Collaborator Author

@AayushSaini101 in commands/generate folder should i have to add proxy support to all three fromTemplate.ts , index.ts and models.ts files ???
yes, understand the flow whenever they are seeking to URL particular URL, you need to configure proxy support

@AayushSaini101
Copy link
Collaborator Author

can I too work on this? @AayushSaini101

@IITI-tushar already working on this issue : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: To Triage
Development

Successfully merging a pull request may close this issue.

3 participants