Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize banner rendering performance to improve Lighthouse score #3335

Open
coderabbitai bot opened this issue Oct 27, 2024 · 9 comments · May be fixed by #3519
Open

Optimize banner rendering performance to improve Lighthouse score #3335

coderabbitai bot opened this issue Oct 27, 2024 · 9 comments · May be fixed by #3519
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers

Comments

@coderabbitai
Copy link

coderabbitai bot commented Oct 27, 2024

In PR #3312 (#3312), optimizing the banner rendering performance was suggested to improve the Lighthouse performance score.

Reference comment: #3312 (comment)

Requested by @akshatnema.

@akshatnema akshatnema removed their assignment Oct 27, 2024
@akshatnema
Copy link
Member

Anyone can take this issue up.

@helios2003
Copy link

Hi @akshatnema, I would like to take up the issue, but my concern is whether there is any need for optimization. Because "banners" are an array of JSON objects with only a few key-value pairs, is optimization required to further improve the rendering process?

@Manancode
Copy link

@akshatnema sir did the suggested changes here but looks like the lighthouse score doesn't have significant changes.
I Will try locally with some more changes/new methods.

@anshgoyalevil anshgoyalevil added good first issue Good for newcomers area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Dec 26, 2024
@IITI-tushar
Copy link

@akshatnema @anshgoyalevil can i work on this???

@anshgoyalevil
Copy link
Member

The issue is open and there's no linked PR, you can work on it.

@ChaitanyaKadu03
Copy link

ChaitanyaKadu03 commented Jan 7, 2025

Hello @IITI-tushar @anshgoyalevil @akshatnema @shubhamku044 @Shurtu-gal,

I'd like to work on [Issue #3335] regarding optimizing the banner rendering performance for better Lighthouse scores.

Request for Assignment

  • Can you please assign this issue to me? I will:
    1. Implement lazy-loading or conditional rendering for inactive banners.
    2. Use CSS transforms for animations or transitions.
    3. Ensure minimal changes to the existing Banner component while improving performance.

Additional Details

  • I’ve already reviewed the related discussion in PR #3312 and have a good idea of how to proceed.
  • I can start working on it as soon as I’m assigned.

Let me know if there's any additional context or requirements.

@IITI-tushar
Copy link

@ChaitanyaKadu03 Thanks for showing interest in this issue. Actually i have opened a PR for this issue that may solve it. Please try to work on another issue.

@ChaitanyaKadu03
Copy link

Hello @IITI-tushar @anshgoyalevil @akshatnema @shubhamku044 @Shurtu-gal,

I'd like to work on [Issue #3335] regarding optimizing the banner rendering performance for better Lighthouse scores.

Request for Assignment

  • Can you please assign this issue to me? I will:

    1. Implement lazy-loading or conditional rendering for inactive banners.
    2. Use CSS transforms for animations or transitions.
    3. Ensure minimal changes to the existing Banner component while improving performance.

Additional Details

  • I’ve already reviewed the related discussion in PR #3312 and have a good idea of how to proceed.
  • I can start working on it as soon as I’m assigned.

Let me know if there's any additional context or requirements.

@IITI-tushar @anshgoyalevil @akshatnema @shubhamku044 @Shurtu-gal your response will mean a lot in this discussion.

@userAdityaa
Copy link

userAdityaa commented Jan 15, 2025

hey is this still work in progress ?
If not I can solve this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers
Projects
None yet
7 participants