Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing "Welcome" Dropdown in Mobile View #3724

Open
2 tasks done
Shriya-Chauhan opened this issue Feb 23, 2025 · 4 comments · May be fixed by #3738
Open
2 tasks done

[BUG] Missing "Welcome" Dropdown in Mobile View #3724

Shriya-Chauhan opened this issue Feb 23, 2025 · 4 comments · May be fixed by #3738
Assignees
Labels

Comments

@Shriya-Chauhan
Copy link
Contributor

Shriya-Chauhan commented Feb 23, 2025

Describe the bug.

The "Welcome" dropdown is missing in the mobile navigation. This results in a confusing UI experience.

Expected behavior

" Welcome " should be appearing on the dropdown for better understanding.

Screenshots

Screenshot_20250224-002750_Chrome.jpg

Screenshot_20250224-002735_Chrome.jpg

How to Reproduce

Open the AsyncAPI Docs on a mobile device or use Chrome DevTools (F12 → Toggle Mobile View).
Look at the navigation sidebar.
Observe that there is no "Welcome" dropdown, making it difficult to understand the hierarchy.

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@Shriya-Chauhan
Copy link
Contributor Author

Hey @anshgoyalevil @devilkiller-ag, I've noticed that the "Welcome" dropdown is missing in the mobile view, likely due to posts.json not having dynamic generation for this section. This affects navigation clarity. Can I go ahead and work on fixing this?

@devilkiller-ag
Copy link
Member

@Shriya-Chauhan Go ahead and open a PR for this issue.

@PRAteek-singHWY
Copy link
Contributor

@devilkiller-ag Hey, I noticed this issue was assigned but no PR has been raised yet.
I have a working fix . Please review my PR .

@Shriya-Chauhan
Copy link
Contributor Author

I believe the root cause is that the content processing in our codebase doesn't properly handle section titles when a _section.mdx file exists in the root directory. While UI fix addresses the symptom, a more comprehensive fix in PR #3741 solves the underlying data generation issue. My approach modifies the walkDirectories function to properly assign section titles from root-level _section.mdx files to all files within that section.

This ensures that the "sectionTitle" property is correctly populated in posts.json for all sections, including the "Welcome" section, which makes it consistently available throughout the application without requiring UI-specific workarounds.

Both approaches can work, but fixing the data at its source will be more maintainable in the long run and prevent similar issues from arising in other parts of the UI.

What do you think @devilkiller-ag ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants