Fix: Ensure full visibility of dropdown menu on medium screens #3745

PRAteek-singHWY · 2025-02-26T16:53:41Z

Description:-

This PR fixes an issue where the dropdown menu under Docs was hiding the icons of Concepts, Guide, References, and Community on medium-sized screens (≥768px).

Changes Made:-

Adjusted md:ml-12 to md:ml-40 in Flyout.tsx, which ensures the dropdown menu shifts properly and does not hide any icons.

Verified the UI consistency across different screen sizes.
Ensured the menu remains fully visible when hovered.

Before:-

After:-

Fixes #3744

Summary by CodeRabbit

Style
- Adjusted the navigation menu’s spacing on medium-sized screens for improved layout.

coderabbitai · 2025-02-26T16:53:48Z

Walkthrough

This pull request updates the layout of the flyout menu in the navigation component by modifying the CSS class applied to a <div> element in the FlyoutMenu.tsx file. The left margin class is updated from md:ml-12 to md:ml-40, thereby adjusting the menu's positioning on medium-sized screens. No changes were made to component logic or public APIs.

Changes

File	Change Summary
`components/navigation/FlyoutMenu.tsx`	Updated `className` from `md:ml-12` to `md:ml-40` to adjust the left margin on medium screens

Suggested labels

ready-to-merge

Suggested reviewers

derberg
akshatnema
devilkiller-ag
sambhavgupta0705
anshgoyalevil
Mayaleeeee

Poem

I'm a rabbit hopping through the code,
A simple tweak on the margin's road.
From twelve to forty, I make a leap,
Shifting layout while the pages sleep.
With a twitch of my nose, I cheer with glee,
Celebrating changes as happy as can be!
🥕 Hop, hop—coding joy is free!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b378c9 and d2f972e.

📒 Files selected for processing (1)

components/navigation/FlyoutMenu.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 180000ms (4)

GitHub Check: Redirect rules - asyncapi-website
GitHub Check: Header rules - asyncapi-website
GitHub Check: Pages changed - asyncapi-website
GitHub Check: Lighthouse CI

🔇 Additional comments (1)

components/navigation/FlyoutMenu.tsx (1)

17-17: Approved: UI positioning fix for medium screens.

The change from md:ml-12 to md:ml-40 increases the left margin from 3rem to 10rem on medium-sized screens (≥768px), which should resolve the issue where the dropdown menu was obscuring the Concepts, Guide, References, and Community icons as described in the PR objectives.

✨ Finishing Touches

📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

asyncapi-bot · 2025-02-26T16:53:54Z

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 Unknown release type "Fix" found in pull request title "Fix: Ensure full visibility of dropdown menu on medium screens". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

netlify · 2025-02-26T16:54:02Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`d2f972e`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/67bf47180022a400081d90a6
😎 Deploy Preview	https://deploy-preview-3745--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2025-02-26T16:55:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b378c9) to head (d2f972e).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #3745   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          732       732           
=========================================
  Hits           732       732

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix: Ensure full visibility of dropdown menu on medium screens

d2f972e

PRAteek-singHWY requested review from derberg, akshatnema, anshgoyalevil, Mayaleeeee and asyncapi-bot-eve as code owners February 26, 2025 16:53

asyncapi-bot requested review from devilkiller-ag and sambhavgupta0705 February 26, 2025 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Ensure full visibility of dropdown menu on medium screens #3745

Fix: Ensure full visibility of dropdown menu on medium screens #3745

PRAteek-singHWY commented Feb 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 26, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

asyncapi-bot commented Feb 26, 2025 •

edited

Loading

netlify bot commented Feb 26, 2025 •

edited

Loading

codecov bot commented Feb 26, 2025

Fix: Ensure full visibility of dropdown menu on medium screens #3745

Are you sure you want to change the base?

Fix: Ensure full visibility of dropdown menu on medium screens #3745

Conversation

PRAteek-singHWY commented Feb 26, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 26, 2025 • edited Loading

Walkthrough

Changes

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

asyncapi-bot commented Feb 26, 2025 • edited Loading

netlify bot commented Feb 26, 2025 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

codecov bot commented Feb 26, 2025

Codecov Report

PRAteek-singHWY commented Feb 26, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 26, 2025 •

edited

Loading

asyncapi-bot commented Feb 26, 2025 •

edited

Loading

netlify bot commented Feb 26, 2025 •

edited

Loading