Keytar 7.0.0 missing Node 12, 13, 14, and 15 prebuilds

[cb1kenobi]

Description

The following prebuilds are missing for all platforms:

• Node 12 - API Version 76
• Node 13 - API Version 79
• Node 14 - API Version 83
• Node 15 - API Version 88

This is a regression as [email protected] has prebuilt binaries for API versions 72, 79, and 83.

Interestingly, there are prebuilds for Node API versions 68, 74, and 81, but there are no Node.js releases with API versions 68, 74, and 81! They don't exist!

If you attempt to install [email protected] using Node 12 or newer, it won't find the prebuilt binary and proceed to compile it. This works fine on my macOS and Linux machines, but on Windows machines, users may not have Python or a C++ compiler.

Steps to Reproduce

1. Use Node 12 (or newer)
2. Install [email protected]

Expected behavior:

Expected the prebuilt binary to exist so that prebuilt-install can download it.

Actual behavior:

Prints out:

prebuild-install WARN install No prebuilt binaries found (target=14.15.0 runtime=node arch=x64 libc= platform=darwin)

Then blows up if you don't have Python or a C++ compiler.

Reproduces how often:

This is reproducible on all platforms.

Versions

Any platform. Any architecture. Node 12 or newer. keytar v7.

Additional Information

Seems this can be mitigated without publishing a new version by just building the missing targets and uploading them to GitHub.

Workaround

The only workaround is to downgrade to [email protected].

[thecryptokhan]

I just got the same result. Will revert to [email protected]

[shiftkey]

Is someone able to test locally and see if this prebuilds any of the right versions are output that'd be a good start:

node-keytar/package.json

Line 37 in 346fdb7

"prebuild-node": "prebuild -t 8.9.0 -t 9.4.0 -t 10.11.0 -t 11.9.0 -t 12.0.0 -t 13.0.0 -t 14.0.0 --strip",

Aside from adding v15 I'm not sure what else to do here to address this 🤔

[cb1kenobi]

I did a bunch of testing, wrote an epic comment detailing my findings, then deleted it. The problem isn't keytar. Its node-abi:

> require('node-abi').getAbi('12.19.0')
'68'

See electron/node-abi#90 and electron/node-abi#93. Someone was kind enough to submit a PR, but even the PR doesn't get things right. Given it's been over a month and no signs of movement on getting this fixed, it might be awhile. Sigh.

[shiftkey]

@cb1kenobi thanks for that writeup. If I can make time this week I'll have a go at publishing a @shiftkey/node-abi package containing that fix which would at least unblock us here.

[shiftkey]

I've taken several attempts at working around the node-abi issue but not found anything satisfactory:

• roll back to 2.18.0 of node-abi means I can't publish prebuilds for Electron 10
• forking into @shiftkey/node-abi doesn't get picked up by prebuild and prebuild-install (so I'd need to at least fork prebuild-install as it's a production dependency)
• use patch-package to apply changes after installing latest version (makes patch-package a production dependency for users to ensure it runs before prebuild-install works)