Skip to content

Db::add_resource_opts is confusing and maybe unneeded #1100

@joepio

Description

@joepio

Some time ago I implemented transaction logic in AtomicServer. However, I still kept the add_resource_opts and the ::set_propvals methods, in addition to the new apply_transaction logic.

Although I don't think this is causing any issues now, it's a potential source for bugs as both implemetations could end up being slightly different (e.g. in how they serialize resources).

I think there are at least these solutions:

  1. Make add_resource_opts depend on add_resource_tx and get rid of set_propvals
  2. Remove add_resource_opts altogether. Is it still needed? We use it in populate and some benchmarks, but I think it might make sense to migrate these to use the transcactional one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions