Skip to content

Duplicate external collections in development #316

Open
@joepio

Description

@joepio

External collections with different URLS (e.g. https://atomicdata.dev/agents, https://atomicdata.dev/agents/ (with trailing slash), https://atomicdata.dev/agents?somequeryparam) are all appearing in a Collection on my local dev setup.

Screenshot 2022-03-11 at 10 14 03

Screenshot 2022-03-11 at 10 17 18

I'm not entirely sure how they have end up in the server at all. The server does cache external resources, but the client is mostly requesting things like these collections. There must be some situations where the server requests these Collections. One possibility is the /path endpoint, which allows for opening any external resource (which happens if you press retry proxy on an error screen).

I want the server to be able to cache external resources, but maybe not this aggressively. Also, I don't want items with various query parameters to end up multiple times (even though I may want to cache them all). Also, I don't want the trailing slash item stored separately.

So maybe these are multiple issues, but maybe I can solve them with one fix:

  • Trailing slash should not count as separate resource
  • Query param resources not appearing in collections
  • Disable external resources by default in collections (I think this makes sense)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinglib rustatomic-lib (rust)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions