Skip to content

chore: auto-install jq on apt-based Linux setups#1436

Merged
atxtechbro merged 2 commits intomainfrom
chore/add-jq-setup
Dec 9, 2025
Merged

chore: auto-install jq on apt-based Linux setups#1436
atxtechbro merged 2 commits intomainfrom
chore/add-jq-setup

Conversation

@atxtechbro
Copy link
Copy Markdown
Owner

Summary

  • ensure setup.sh installs jq on apt-based Linux/WSL when missing

Testing

  • not run (non-executable change)

@amazon-q-developer
Copy link
Copy Markdown
Contributor

Code review in progress. Analyzing for code quality issues and best practices. You can monitor the review status in the checks section at the bottom of this pull request. Detailed findings will be posted upon completion.

Using Amazon Q Developer for GitHub

Amazon Q Developer1 is an AI-powered assistant that integrates directly into your GitHub workflow, enhancing your development process with intelligent features for code development, review, and transformation.

Slash Commands

Command Description
/q <message> Chat with the agent to ask questions or request revisions
/q review Requests an Amazon Q powered code review
/q help Displays usage information

Features

Agentic Chat
Enables interactive conversation with Amazon Q to ask questions about the pull request or request specific revisions. Use /q <message> in comment threads or the review body to engage with the agent directly.

Code Review
Analyzes pull requests for code quality, potential issues, and security concerns. Provides feedback and suggested fixes. Automatically triggered on new or reopened PRs (can be disabled for AWS registered installations), or manually with /q review slash command in a comment.

Customization

You can create project-specific rules for Amazon Q Developer to follow:

  1. Create a .amazonq/rules folder in your project root.
  2. Add Markdown files in this folder to define rules (e.g., cdk-rules.md).
  3. Write detailed prompts in these files, such as coding standards or best practices.
  4. Amazon Q Developer will automatically use these rules when generating code or providing assistance.

Example rule:

All Amazon S3 buckets must have encryption enabled, enforce SSL, and block public access.
All Amazon DynamoDB Streams tables must have encryption enabled.
All Amazon SNS topics must have encryption enabled and enforce SSL.
All Amazon SNS queues must enforce SSL.

Feedback

To provide feedback on Amazon Q Developer, create an issue in the Amazon Q Developer public repository.

For more detailed information, visit the Amazon Q for GitHub documentation.

Footnotes

  1. Amazon Q Developer uses generative AI. You may need to verify generated code before using it in your environment. See the AWS Responsible AI Policy.

Copy link
Copy Markdown
Contributor

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This PR adds automatic jq installation for apt-based Linux systems, which is a useful enhancement for ensuring dependencies are available. However, there are some reliability and error handling concerns that should be addressed:

Key Issues:

  1. Command execution reliability: The current subshell approach with || could mask failures and leave the system in an inconsistent state
  2. Logic optimization: The condition checking can be streamlined for better readability and performance

Recommendations:

  • Restructure the error handling to avoid silent failures during package installation
  • Simplify the conditional logic to check for jq availability first
  • Add user feedback during the installation process

The changes are straightforward and the intent is clear, but improving the error handling will make this more robust for production use.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

setup.sh Outdated

# Ensure jq is present on apt-based Linux/WSL
if [[ "$OS_TYPE" == "Linux" ]] && command -v apt-get >/dev/null; then
command -v jq >/dev/null || (sudo apt-get update -y && sudo apt-get install -y jq)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Command Injection Risk: The command substitution in the subshell could fail silently and leave the system in an inconsistent state. If sudo apt-get update fails, apt-get install will still execute with potentially stale package information.

Suggested change
command -v jq >/dev/null || (sudo apt-get update -y && sudo apt-get install -y jq)
if ! command -v jq >/dev/null; then
echo "Installing jq..."
sudo apt-get update -y && sudo apt-get install -y jq
fi

Co-authored-by: amazon-q-developer[bot] <208079219+amazon-q-developer[bot]@users.noreply.github.com>
@atxtechbro atxtechbro merged commit adfd78d into main Dec 9, 2025
@atxtechbro atxtechbro deleted the chore/add-jq-setup branch December 9, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant