rubocop changes in bulk update

Author: Nevelito

app/components/avo/views/resource_edit_component.rb

@@ -26,7 +26,7 @@ def title
   end
 
   def back_path
-    return helpers.resources_path(resource: @resource) if params[:controller] == 'avo/bulk_update'
+    return helpers.resources_path(resource: @resource) if params[:controller] == "avo/bulk_update"
 
     # The `return_to` param takes precedence over anything else.
     return params[:return_to] if params[:return_to].present?
@@ -86,7 +86,7 @@ def is_edit?
   end
 
   def form_method
-    return :put if is_edit? && params[:controller] != 'avo/bulk_update'
+    return :put if is_edit? && params[:controller] != "avo/bulk_update"
 
     :post
   end
@@ -96,7 +96,7 @@ def model
   end
 
   def form_url
-    if params[:controller] == 'avo/bulk_update'
+    if params[:controller] == "avo/bulk_update"
       helpers.handle_bulk_update_path(resource_name: @resource.name, query: @query)
     elsif is_edit?
       helpers.resource_path(

app/controllers/avo/bulk_update_controller.rb

@@ -42,51 +42,44 @@ def params_to_apply
       current_params = params[resource_key] || {}
 
       progress_fields = @resource
-        .get_field_definitions
-        .select { |field| field.is_a?(Avo::Fields::ProgressBarField) }
-        .map(&:id)
-        .map(&:to_sym)
+                          .get_field_definitions
+                          .select { |field| field.is_a?(Avo::Fields::ProgressBarField) }
+                          .map(&:id)
+                          .map(&:to_sym)
 
-
-      params_to_apply = current_params.reject do |key, value|
+      current_params.reject do |key, value|
         key_sym = key.to_sym
         prefilled_value = prefilled_params[key_sym]
 
         next true if progress_fields.include?(key_sym) && prefilled_value == "" && value.to_s == "50"
 
         prefilled_value.to_s == value.to_s
       end
-
-      params_to_apply
     end
 
     def update_records
       updated_count = 0
       failed_records = []
 
       @query.each do |record|
-        begin
-          params_to_apply.each do |key, value|
-            begin
-              record.public_send("#{key}=", value)
-            rescue => e
-              puts "Błąd przypisywania pola #{key}: #{e.message}"
-            end
-          end
-
-          @resource.fill_record(record, params)
-
-          if record.save
-            updated_count += 1
-          else
-            failed_records << { record: record, errors: record.errors.full_messages }
-          end
+        params_to_apply.each do |key, value|
+          record.public_send(:"#{key}=", value)
         rescue => e
-          failed_records << { record: record, errors: [e.message] }
+          puts "Błąd przypisywania pola #{key}: #{e.message}"
+        end
+
+        @resource.fill_record(record, params)
+
+        if record.save
+          updated_count += 1
+        else
+          failed_records << { record: record, errors: record.errors.full_messages }
         end
+      rescue => e
+        failed_records << { record: record, errors: [e.message] }
       end
 
-      return updated_count, failed_records
+      [updated_count, failed_records]
     end
 
     def after_bulk_update_path

config/routes.rb

@@ -4,11 +4,6 @@
   get "resources", to: redirect(Avo.configuration.root_path)
   get "dashboards", to: redirect(Avo.configuration.root_path)
 
-  # Mount Avo engines routes by default but leave it configurable in case the user wants to nest these under a scope.
-  if Avo.configuration.mount_avo_engines
-    instance_exec(&Avo.mount_engines)
-  end
-
   get "/bulk_update/edit", to: "bulk_update#edit", as: "edit_bulk_update"
   post "/bulk_update/handle", to: "bulk_update#handle", as: "handle_bulk_update"