Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve select all query serialization #3167

Closed
3 tasks
Paul-Bob opened this issue Aug 21, 2024 · 1 comment
Closed
3 tasks

Improve select all query serialization #3167

Paul-Bob opened this issue Aug 21, 2024 · 1 comment

Comments

@Paul-Bob
Copy link
Contributor

Paul-Bob commented Aug 21, 2024

When the "Select All" feature is used and an action is triggered, we need to reconstruct the complete query within the action request.

image

Since the query might include various filters and custom elements, it’s not simple to rebuild it during the action request. To handle this, we serialize and encrypt the entire query (for security) before passing it along with the action request. (An alternative approach could be to only serialize when "Select All" is pressed, but that’s a discussion for another time.)

We’re always open to feedback and suggestions for improvement.

One alternative might be to extract all the IDs from the query, encrypt them as an array, and then retrieve the records using those IDs.

Originally posted by @Paul-Bob in #3151 (comment)

One alternative might be to extract all the IDs from the query, encrypt them as an array, and then retrieve the records using those IDs.

This approach is not suitable for scaling (millions of IDs may break it)

For now, let's make some DX improvements:

Tasks

@adrianthedev
Copy link
Collaborator

Closing for now until we see further feedback on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants