Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have integers be deserialized as number not bigint #20

Open
OlafConijn opened this issue Aug 15, 2020 · 2 comments
Open

Have integers be deserialized as number not bigint #20

OlafConijn opened this issue Aug 15, 2020 · 2 comments
Labels
question Further information is requested

Comments

@OlafConijn
Copy link

hi, passing bigints to the aws-sdk will result in an error. maybe use numbers instead?

@eduardomourar
Copy link
Contributor

eduardomourar commented Aug 15, 2020

The way I solved this is by converting to number during serialization of a bigint. So you should always pass down the plain object to the AWS SDK by invoking the serialize method.

I wanted to keep a distinction between integer and float numbers, but we can revisit that in case it becomes too complicated or not intuitive.

@eduardomourar eduardomourar added the question Further information is requested label Nov 29, 2020
@eduardomourar
Copy link
Contributor

The reason for creating our own BigInt type is lack of serialization support (more details here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants