Filter on ServiceID

- Add hook to fail fast if ServiceID not set
- Add hook to include ServiceID as filter for ReadMany API request
- undo code-gen change to fail matching criteria check for nil Status fields

Author: knottnt

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2025-07-22T22:13:44Z"
+  build_date: "2025-07-24T18:21:24Z"
   build_hash: b2dc0f44e0b08f041de14c3944a5cc005ba97c8f
   go_version: go1.24.5
   version: v0.50.0
 api_directory_checksum: d162a6e9df2d4861d6c01d42047402b51f341293
 api_version: v1alpha1
 aws_sdk_go_version: v1.32.6
 generator_config_info:
-  file_checksum: a3b7769e44651dbf7cdf955e76e47458b3436550
+  file_checksum: c1b1b2a01e8d9f0971cc42f937b92fc9bb0d2987
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -1075,6 +1075,10 @@ resources:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_update_pre_build_request.go.tpl
       sdk_read_many_post_set_output:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_set_output.go.tpl
+      sdk_read_many_pre_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_pre_build_request.go.tpl
+      sdk_read_many_post_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_build_request.go.tpl
   VpcPeeringConnection:
     fields:      
       VpcId:

generator.yaml

@@ -1075,6 +1075,10 @@ resources:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_update_pre_build_request.go.tpl
       sdk_read_many_post_set_output:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_set_output.go.tpl
+      sdk_read_many_pre_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_pre_build_request.go.tpl
+      sdk_read_many_post_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_build_request.go.tpl
   VpcPeeringConnection:
     fields:      
       VpcId:

pkg/resource/elastic_ip_address/sdk.go

@@ -0,0 +1,3 @@
+	if r.ko.Status.ServiceID != nil {
+		input.ServiceIds = []string{*r.ko.Status.ServiceID}
+	}

pkg/resource/vpc_endpoint_service_configuration/sdk.go

@@ -0,0 +1,3 @@
+    if r.ko.Status.ServiceID == nil {
+		return nil, ackerr.NotFound
+	}

templates/hooks/vpc_endpoint_service_configuration/sdk_read_many_post_build_request.go.tpl

@@ -94,27 +94,33 @@ def test_vpc_endpoint_service_configuration_adopt_update(self, ec2_client, vpc_e
         ec2_validator = EC2Validator(ec2_client)
         ec2_validator.assert_vpc_endpoint_service_configuration(resource_id)
 
-        endpoint_service_config = ec2_validator.get_vpc_endpoint_service_configuration(resource_id)
+        updated_endpoint_service_config = ec2_validator.get_vpc_endpoint_service_configuration(resource_id)
 
-        actual_tags = endpoint_service_config['Tags']
+        actual_tags = updated_endpoint_service_config['Tags']
         tags.assert_ack_system_tags(actual_tags)
 
         name_tag = next((tag for tag in actual_tags if tag['Key'] == 'Name'), None)
         assert name_tag is not None
 
-        new_tag = {'Key': 'TestName', 'Value': 'test-value'}
+        name_tag = {'key': 'Name', 'value': name_tag['Value']}
+        new_tag = {'key': 'TestName', 'value': 'test-value'}
         updates = {
             "spec": {"tags": [name_tag, new_tag]}
         }
+        
         k8s.patch_custom_resource(ref, updates)
         time.sleep(MODIFY_WAIT_AFTER_SECONDS)
 
         assert k8s.wait_on_condition(ref, "ACK.ResourceSynced", "True", wait_periods=5)
 
-        endpoint_service_config = ec2_validator.get_vpc_endpoint_service_configuration(resource_id)
+        updated_endpoint_service_config = ec2_validator.get_vpc_endpoint_service_configuration(resource_id)
+        assert updated_endpoint_service_config is not None
+        assert 'Tags' in updated_endpoint_service_config
+        
+        expected_tags = [{"Key": name_tag['key'], "Value": name_tag['value']},  {"Key": new_tag['key'], "Value": new_tag['value']}]
         tags.assert_equal_without_ack_tags(
-            actual=endpoint_service_config['Tags'],
-            expected=[name_tag, new_tag],
+            actual=updated_endpoint_service_config['Tags'],
+            expected=expected_tags,
         )