Filter on ServiceID

knottnt · knottnt · commit 2d7939b3dfd1 · 2025-07-23T22:24:16.000-07:00
- Add hook to fail fast if ServiceID not set
- Add hook to include ServiceID as filter for ReadMany API request
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2025-07-22T22:13:44Z"
-  build_hash: b2dc0f44e0b08f041de14c3944a5cc005ba97c8f
+  build_date: "2025-07-23T22:51:43Z"
+  build_hash: 13d54b574bceb0f0f5170a2ac1a50cd65a4269a5
   go_version: go1.24.5
-  version: v0.50.0
+  version: v0.50.0-1-g13d54b5
 api_directory_checksum: d162a6e9df2d4861d6c01d42047402b51f341293
 api_version: v1alpha1
 aws_sdk_go_version: v1.32.6
 generator_config_info:
-  file_checksum: a3b7769e44651dbf7cdf955e76e47458b3436550
+  file_checksum: c1b1b2a01e8d9f0971cc42f937b92fc9bb0d2987
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
diff --git a/apis/v1alpha1/generator.yaml b/apis/v1alpha1/generator.yaml
@@ -1075,6 +1075,10 @@ resources:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_update_pre_build_request.go.tpl
       sdk_read_many_post_set_output:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_set_output.go.tpl
+      sdk_read_many_pre_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_pre_build_request.go.tpl
+      sdk_read_many_post_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_build_request.go.tpl
   VpcPeeringConnection:
     fields:      
       VpcId:
diff --git a/generator.yaml b/generator.yaml
@@ -1075,6 +1075,10 @@ resources:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_update_pre_build_request.go.tpl
       sdk_read_many_post_set_output:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_set_output.go.tpl
+      sdk_read_many_pre_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_pre_build_request.go.tpl
+      sdk_read_many_post_build_request:
+        template_path: hooks/vpc_endpoint_service_configuration/sdk_read_many_post_build_request.go.tpl
   VpcPeeringConnection:
     fields:      
       VpcId:
diff --git a/pkg/resource/vpc_endpoint_service_configuration/sdk.go b/pkg/resource/vpc_endpoint_service_configuration/sdk.go
diff --git a/templates/hooks/vpc_endpoint_service_configuration/sdk_read_many_post_build_request.go.tpl b/templates/hooks/vpc_endpoint_service_configuration/sdk_read_many_post_build_request.go.tpl
@@ -0,0 +1,3 @@
+	if r.ko.Status.ServiceID != nil {
+		input.ServiceIds = []string{*r.ko.Status.ServiceID}
+	}
diff --git a/templates/hooks/vpc_endpoint_service_configuration/sdk_read_many_pre_build_request.go.tpl b/templates/hooks/vpc_endpoint_service_configuration/sdk_read_many_pre_build_request.go.tpl
@@ -0,0 +1,3 @@
+    if r.ko.Status.ServiceID == nil {
+		return nil, ackerr.NotFound
+	}
diff --git a/test/e2e/tests/test_vpc_endpoint_service_configuration_adoption.py b/test/e2e/tests/test_vpc_endpoint_service_configuration_adoption.py
@@ -94,7 +94,6 @@ def test_vpc_endpoint_service_configuration_adopt_update(self, ec2_client, vpc_e
         ec2_validator = EC2Validator(ec2_client)
         ec2_validator.assert_vpc_endpoint_service_configuration(resource_id)
 
-        endpoint_service_config = ec2_validator.get_vpc_endpoint_service_configuration(resource_id)
 
         actual_tags = endpoint_service_config['Tags']
         tags.assert_ack_system_tags(actual_tags)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+ if r.ko.Status.ServiceID != nil {`
	`2`	`+ input.ServiceIds = []string{*r.ko.Status.ServiceID}`
	`3`	`+ }`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+ if r.ko.Status.ServiceID == nil {`
	`2`	`+ return nil, ackerr.NotFound`
	`3`	`+ }`