Skip to content

Commit 97fb6b2

Browse files
authored
Ignore TransitEncryptionEnabled in modify when unchanged (#171)
If the `TransitEncryptionEnabled` value is unchanged, but added to a ModifyReplicationGroup call, the ElastiCache API will return an errorMessage saying: > Modification of transit encryption is not supported for access control > enabled clusters. This is "fixed" by not setting it, or setting it to nil. Fixes aws-controllers-k8s/community#2536 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 6a403f8 commit 97fb6b2

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
ack_generate_info:
2-
build_date: "2025-06-11T00:03:37Z"
3-
build_hash: e675923dfc54d8b6e09730098c3e3e1056d3c1e9
4-
go_version: go1.24.3
5-
version: v0.48.0
2+
build_date: "2025-06-24T10:48:48Z"
3+
build_hash: a488d4e8a9222ed51e5690cb5850beb21cce5a1f
4+
go_version: go1.24.2
5+
version: v0.48.0-1-ga488d4e
66
api_directory_checksum: e7d8480a655968a4f441db9509fd5561aa5eb1c4
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6

pkg/resource/replication_group/sdk.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

templates/hooks/replication_group/sdk_update_post_build_request.go.tpl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
if !delta.DifferentAt("Spec.LogDeliveryConfigurations") {
22
input.LogDeliveryConfigurations = nil
33
}
4+
if !delta.DifferentAt("Spec.TransitEncryptionEnabled") {
5+
input.TransitEncryptionEnabled = nil
6+
}
47
if delta.DifferentAt("UserGroupIDs") {
58
for _, diff := range delta.Differences {
69
if diff.Path.Contains("UserGroupIDs") {
@@ -54,4 +57,4 @@
5457
}
5558
}
5659
}
57-
}
60+
}

0 commit comments

Comments
 (0)