Skip to content

Commit 01a6cdd

Browse files
authored
Updates ACK runtime to v0.14.1 (#34)
No other functional changes included other than runtime update. Signed-off-by: Jay Pipes <[email protected]> By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent a93d155 commit 01a6cdd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+178
-110
lines changed

CODE_OF_CONDUCT.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
## Code of Conduct
2-
32
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
43
For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
54
[email protected] with any additional questions or comments.
6-

CONTRIBUTING.md

Lines changed: 52 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,51 +1,85 @@
11
# Contributing Guidelines
22

3-
Thank you for your interest in contributing to our project. Whether it's a bug report, new feature, correction, or additional documentation, we greatly value feedback and contributions from our community.
3+
Thank you for your interest in contributing to our project. Whether it's a bug
4+
report, new feature, correction, or additional documentation, we greatly value
5+
feedback and contributions from our community.
46

5-
Please read through this document before submitting any issues or pull requests to ensure we have all the necessary information to effectively respond to your bug report or contribution.
7+
Please read through this document before submitting any issues or pull requests
8+
to ensure we have all the necessary information to effectively respond to your
9+
bug report or contribution.
610

711
## Reporting Bugs/Feature Requests
812

9-
We welcome you to use the GitHub issue tracker to report bugs or suggest features.
13+
We welcome you to use the GitHub issue tracker to report bugs or suggest
14+
features.
1015

11-
When filing an issue, please check existing open, or recently closed, issues to make sure somebody else hasn't already reported the issue. Please try to include as much information as you can. Details like these are incredibly useful:
16+
When filing an issue, please check existing open, or recently closed, issues to
17+
make sure somebody else hasn't already reported the issue. Please try to
18+
include as much information as you can. Details like these are incredibly
19+
useful:
1220

1321
* A reproducible test case or series of steps
1422
* The version of our code being used
1523
* Any modifications you've made relevant to the bug
1624
* Anything unusual about your environment or deployment
1725

1826
## Contributing via Pull Requests
19-
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
27+
28+
Contributions via pull requests are much appreciated. Before sending us a pull
29+
request, please ensure that:
2030

2131
1. You are working against the latest source on the *main* branch.
22-
2. You check existing open, and recently merged, pull requests to make sure someone else hasn't addressed the problem already.
23-
3. You open an issue to discuss any significant work - we would hate for your time to be wasted.
32+
2. You check existing open, and recently merged, pull requests to make sure
33+
someone else hasn't addressed the problem already.
34+
3. You open an issue to discuss any significant work - we would hate for your
35+
time to be wasted.
2436

2537
To send us a pull request, please:
2638

2739
1. Fork the repository.
28-
2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
40+
2. Modify the source; please focus on the specific change you are contributing.
41+
If you also reformat all the code, it will be hard for us to focus on your
42+
change.
2943
3. Ensure local tests pass.
3044
4. Commit to your fork using clear commit messages.
31-
5. Send us a pull request, answering any default questions in the pull request interface.
32-
6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
45+
5. Send us a pull request, answering any default questions in the pull request
46+
interface.
47+
6. Pay attention to any automated CI failures reported in the pull request, and
48+
stay involved in the conversation.
49+
50+
GitHub provides additional document on [forking a repository][fork] and
51+
[creating a pull request][pr].
3352

34-
GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and [creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
53+
[fork]: https://help.github.com/articles/fork-a-repo/
54+
[pr]: https://help.github.com/articles/creating-a-pull-request/
3555

3656
## Finding contributions to work on
37-
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels (enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any 'help wanted' issues is a great place to start.
57+
58+
Looking at the existing issues is a great way to find something to contribute
59+
on. As our projects, by default, use the default GitHub issue labels
60+
(enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at
61+
any 'help wanted' issues is a great place to start.
3862

3963
## Developer documentation
40-
[See the documentation](https://aws-controllers-k8s.github.io/community/dev-docs/overview/) for detailed development information.
64+
65+
[See the documentation][dev-docs] for detailed development information.
66+
67+
[dev-docs]: https://aws-controllers-k8s.github.io/community/docs/contributor-docs/overview/
4168

4269
## Code of Conduct
43-
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
4470

45-
For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact [email protected] with any additional questions or comments.
71+
We adhere to the [Amazon Open Source Code of Conduct][coc].
72+
73+
[coc]: https://aws.github.io/code-of-conduct
4674

4775
## Security issue notifications
48-
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
4976

50-
## Licensing
51-
See the [LICENSE](LICENSE) file for our project's licensing. We will ask you to confirm the licensing of your contribution.
77+
If you discover a potential security issue in this project we ask that you
78+
notify AWS/Amazon Security via our [vulnerability reporting page][vuln]. Please
79+
do **not** create a public Github issue.
80+
81+
[vuln]: http://aws.amazon.com/security/vulnerability-reporting/
82+
83+
## License
84+
85+
This project is [licensed][./LICENSE] under the Apache-2.0 License.

GOVERNANCE.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ In the context of ACK, we consider the following roles:
99

1010
* __Users__ ... everyone using ACK, typically willing to provide feedback on ACK by proposing features and/or filing issues.
1111
* __Contributors__ ... everyone contributing code, documentation, examples, testing infra, and participating in feature proposals as well as design discussions. Code contributions will require a Developer Certificate of Origin (DCO).
12-
* __Maintainers__ ... are responsible for engaging with and assisting contributors to iterate on the contributions until it reaches acceptable quality. Maintainers can decide whether the contributions can be accepted into the project or rejected. Any active contributor meeting the project quality can be made a Maintainer by the Advisory Board.
13-
* __Advisory Board__ ... is responsible for defining the guidelines and processes that the project operates under.
12+
* __Maintainers__ ... are responsible for engaging with and assisting contributors to iterate on the contributions until it reaches acceptable quality. Maintainers can decide whether the contributions can be accepted into the project or rejected. Any active contributor meeting the project quality can be made a Maintainer by the Advisory Board.
13+
* __Advisory Board__ ... is responsible for defining the guidelines and processes that the project operates under.
1414

1515
The initial members of the Advisory Board are `@jaypipes` and `@mhausenblas`.
1616

@@ -34,4 +34,3 @@ The Advisory Board will propose a release management proposal via a GitHub issue
3434

3535
* The ACK [Contributing Guidelines](CONTRIBUTING.md)
3636
* Our [Code of Conduct](CODE_OF_CONDUCT.md)
37-

LICENSE

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,4 +173,3 @@
173173
defend, and hold each Contributor harmless for any liability
174174
incurred by, or claims asserted against, such Contributor by reason
175175
of your accepting any such warranty or additional liability.
176-

NOTICE

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
2-
1+
Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,13 @@
11
ack_generate_info:
2-
build_date: "2021-09-01T14:48:37Z"
3-
build_hash: 6f22b7b568e25b4ee007bb1ab5f9338c16daf172
4-
go_version: go1.17 linux/amd64
5-
version: v0.13.0
2+
build_date: "2021-09-30T17:17:12Z"
3+
build_hash: 2b0ac062dd6d305434d252b5da5ed718c801b106
4+
go_version: go1.17
5+
version: v0.14.1
66
api_directory_checksum: 183f450ec5188cdb1cf76da50f21933f6b4cd7e3
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.37.10
99
generator_config_info:
10-
file_checksum: f62cefeb4c379bb1cc428d6685a4e5e4e182eb92
10+
file_checksum: e6d75d736bdcf3b5649f48ac2945fff9041b44f8
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation
14-
timestamp: 2021-09-01 14:48:42.205143913 +0000 UTC

apis/v1alpha1/generator.yaml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,6 @@ operations:
5858
# points to the build_request methods to enable a genmeration of the
5959
# final snapshot identifier to use.
6060
SkipFinalSnapshot: true
61-
DescribeDBInstances:
62-
primary_identifier_field_name: DBInstanceIdentifier
63-
DescribeDBClusterParameterGroups:
64-
primary_identifier_field_name: DBClusterParameterGroupName
65-
DescribeDBClusters:
66-
primary_identifier_field_name: DBClusterIdentifier
67-
DescribeDBParameterGroups:
68-
primary_identifier_field_name: DBParameterGroupName
69-
DescribeDBSecurityGroups:
70-
primary_identifier_field_name: DBSecurityGroupName
71-
DescribeDBSubnetGroups:
72-
primary_identifier_field_name: DBSubnetGroupName
7361
resources:
7462
DBCluster:
7563
update_operation:
@@ -100,6 +88,8 @@ resources:
10088
- KMSKeyNotAccessibleFault
10189
- StorageQuotaExceeded
10290
fields:
91+
DBClusterIdentifier:
92+
is_primary_key: true
10393
MasterUserPassword:
10494
is_secret: true
10595
DBClusterParameterGroup:
@@ -116,6 +106,8 @@ resources:
116106
input_fields:
117107
DBClusterParameterGroupName: Name
118108
fields:
109+
Name:
110+
is_primary_key: true
119111
Parameters:
120112
from:
121113
operation: ModifyDBClusterParameterGroup
@@ -148,6 +140,8 @@ resources:
148140
- DBSubnetGroupNotFoundFault
149141
- DBParameterGroupNotFound
150142
fields:
143+
DBInstanceIdentifier:
144+
is_primary_key: true
151145
MasterUserPassword:
152146
is_secret: true
153147
DBParameterGroup:
@@ -164,6 +158,8 @@ resources:
164158
input_fields:
165159
DBParameterGroupName: Name
166160
fields:
161+
Name:
162+
is_primary_key: true
167163
Parameters:
168164
from:
169165
operation: ModifyDBParameterGroup
@@ -181,6 +177,9 @@ resources:
181177
DeleteDBSecurityGroup:
182178
input_fields:
183179
DBSecurityGroupName: Name
180+
fields:
181+
Name:
182+
is_primary_key: true
184183
DBSubnetGroup:
185184
renames:
186185
operations:
@@ -194,3 +193,6 @@ resources:
194193
DeleteDBSubnetGroup:
195194
input_fields:
196195
DBSubnetGroupName: Name
196+
fields:
197+
Name:
198+
is_primary_key: true

config/controller/deployment.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ spec:
4141
image: controller:latest
4242
name: controller
4343
ports:
44-
- containerPort: 8080
44+
- name: http
45+
containerPort: 8080
4546
resources:
4647
limits:
4748
cpu: 100m

config/controller/service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ spec:
99
ports:
1010
- name: metricsport
1111
port: 8080
12-
targetPort: 8080
12+
targetPort: http
1313
protocol: TCP
14-
type: NodePort
14+
type: NodePort

config/crd/bases/rds.services.k8s.aws_dbclusterparametergroups.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.6.1
7+
controller-gen.kubebuilder.io/version: v0.7.0
88
creationTimestamp: null
99
name: dbclusterparametergroups.rds.services.k8s.aws
1010
spec:

config/crd/bases/rds.services.k8s.aws_dbclusters.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.6.1
7+
controller-gen.kubebuilder.io/version: v0.7.0
88
creationTimestamp: null
99
name: dbclusters.rds.services.k8s.aws
1010
spec:

config/crd/bases/rds.services.k8s.aws_dbinstances.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.6.1
7+
controller-gen.kubebuilder.io/version: v0.7.0
88
creationTimestamp: null
99
name: dbinstances.rds.services.k8s.aws
1010
spec:

config/crd/bases/rds.services.k8s.aws_dbparametergroups.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.6.1
7+
controller-gen.kubebuilder.io/version: v0.7.0
88
creationTimestamp: null
99
name: dbparametergroups.rds.services.k8s.aws
1010
spec:

config/crd/bases/rds.services.k8s.aws_dbsecuritygroups.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.6.1
7+
controller-gen.kubebuilder.io/version: v0.7.0
88
creationTimestamp: null
99
name: dbsecuritygroups.rds.services.k8s.aws
1010
spec:

config/crd/bases/rds.services.k8s.aws_dbsubnetgroups.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1
44
kind: CustomResourceDefinition
55
metadata:
66
annotations:
7-
controller-gen.kubebuilder.io/version: v0.6.1
7+
controller-gen.kubebuilder.io/version: v0.7.0
88
creationTimestamp: null
99
name: dbsubnetgroups.rds.services.k8s.aws
1010
spec:

generator.yaml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,18 +58,6 @@ operations:
5858
# points to the build_request methods to enable a genmeration of the
5959
# final snapshot identifier to use.
6060
SkipFinalSnapshot: true
61-
DescribeDBInstances:
62-
primary_identifier_field_name: DBInstanceIdentifier
63-
DescribeDBClusterParameterGroups:
64-
primary_identifier_field_name: DBClusterParameterGroupName
65-
DescribeDBClusters:
66-
primary_identifier_field_name: DBClusterIdentifier
67-
DescribeDBParameterGroups:
68-
primary_identifier_field_name: DBParameterGroupName
69-
DescribeDBSecurityGroups:
70-
primary_identifier_field_name: DBSecurityGroupName
71-
DescribeDBSubnetGroups:
72-
primary_identifier_field_name: DBSubnetGroupName
7361
resources:
7462
DBCluster:
7563
update_operation:
@@ -100,6 +88,8 @@ resources:
10088
- KMSKeyNotAccessibleFault
10189
- StorageQuotaExceeded
10290
fields:
91+
DBClusterIdentifier:
92+
is_primary_key: true
10393
MasterUserPassword:
10494
is_secret: true
10595
DBClusterParameterGroup:
@@ -116,6 +106,8 @@ resources:
116106
input_fields:
117107
DBClusterParameterGroupName: Name
118108
fields:
109+
Name:
110+
is_primary_key: true
119111
Parameters:
120112
from:
121113
operation: ModifyDBClusterParameterGroup
@@ -148,6 +140,8 @@ resources:
148140
- DBSubnetGroupNotFoundFault
149141
- DBParameterGroupNotFound
150142
fields:
143+
DBInstanceIdentifier:
144+
is_primary_key: true
151145
MasterUserPassword:
152146
is_secret: true
153147
DBParameterGroup:
@@ -164,6 +158,8 @@ resources:
164158
input_fields:
165159
DBParameterGroupName: Name
166160
fields:
161+
Name:
162+
is_primary_key: true
167163
Parameters:
168164
from:
169165
operation: ModifyDBParameterGroup
@@ -181,6 +177,9 @@ resources:
181177
DeleteDBSecurityGroup:
182178
input_fields:
183179
DBSecurityGroupName: Name
180+
fields:
181+
Name:
182+
is_primary_key: true
184183
DBSubnetGroup:
185184
renames:
186185
operations:
@@ -194,3 +193,6 @@ resources:
194193
DeleteDBSubnetGroup:
195194
input_fields:
196195
DBSubnetGroupName: Name
196+
fields:
197+
Name:
198+
is_primary_key: true

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module github.com/aws-controllers-k8s/rds-controller
33
go 1.14
44

55
require (
6-
github.com/aws-controllers-k8s/runtime v0.13.0
6+
github.com/aws-controllers-k8s/runtime v0.14.1
77
github.com/aws/aws-sdk-go v1.37.10
88
github.com/go-logr/logr v0.1.0
99
github.com/spf13/pflag v1.0.5

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883/go.mod h1:rCTlJbsFo
2323
github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8=
2424
github.com/asaskevich/govalidator v0.0.0-20180720115003-f9ffefc3facf/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
2525
github.com/asaskevich/govalidator v0.0.0-20190424111038-f61b66f89f4a/go.mod h1:lB+ZfQJz7igIIfQNfa7Ml4HSf2uFQQRzpGGRXenZAgY=
26-
github.com/aws-controllers-k8s/runtime v0.13.0 h1:PYiNnQejjS/1H93bolFXGIzgQZSn/gRoPSAEU6UG0ec=
27-
github.com/aws-controllers-k8s/runtime v0.13.0/go.mod h1:kG2WM4JAmLgf67cgZV9IZUkY2DsrUzsaNbmhFMfb05c=
26+
github.com/aws-controllers-k8s/runtime v0.14.1 h1:2/hCwost9rmtgsgktCtJH75U74ziWiBs0bHFOB2iaKo=
27+
github.com/aws-controllers-k8s/runtime v0.14.1/go.mod h1:kG2WM4JAmLgf67cgZV9IZUkY2DsrUzsaNbmhFMfb05c=
2828
github.com/aws/aws-sdk-go v1.37.10 h1:LRwl+97B4D69Z7tz+eRUxJ1C7baBaIYhgrn5eLtua+Q=
2929
github.com/aws/aws-sdk-go v1.37.10/go.mod h1:hcU610XS61/+aQV88ixoOzUoG7v3b31pl2zKMmprdro=
3030
github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q=

0 commit comments

Comments
 (0)