Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws-controllers-k8s/rds-controller
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.18
Choose a base ref
...
head repository: aws-controllers-k8s/rds-controller
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 5 commits
  • 20 files changed
  • 3 contributors

Commits on May 27, 2025

  1. Update to ACK runtime v0.47.0, code-generator v0.47.1 (#224) 

    ### Update to ACK runtime `v0.47.0`, code-generator `v0.47.1`

----------

* ACK code-generator `v0.47.1` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.47.1)
* ACK runtime `v0.47.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.47.0)

----------

NOTE:
This PR increments the release version of service controller from `v1.4.18` to `v1.4.19`

Once this PR is merged, release `v1.4.19` will be automatically created for `rds-controller`

**Please close this PR, if you do not want the new patch release for `rds-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building rds-controller ====
Copying common custom resource definitions into rds
Building Kubernetes API objects for rds
Generating deepcopy code for rds
Generating custom resource definitions for rds
Building service controller for rds
Running GO mod tidy
Generating RBAC manifests for rds
Running gofmt against generated code for rds
Updating additional GitHub repository maintenance files
==== building rds-controller release artifacts ====
Building release artifacts for rds-v1.4.19
Generating common custom resource definitions
Generating custom resource definitions for rds
Generating RBAC manifests for rds
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    @ack-bot
    ack-bot authored May 27, 2025
    Copy the full SHA
    f068bcf View commit details

Commits on Jun 3, 2025

  1. Update to ACK runtime v0.47.0, code-generator v0.47.2 (#225) 

    ### Update to ACK runtime `v0.47.0`, code-generator `v0.47.2`

----------

* ACK code-generator `v0.47.2` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.47.2)
* ACK runtime `v0.47.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.47.0)

----------

NOTE:
This PR increments the release version of service controller from `v1.4.19` to `v1.4.20`

Once this PR is merged, release `v1.4.20` will be automatically created for `rds-controller`

**Please close this PR, if you do not want the new patch release for `rds-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building rds-controller ====
Copying common custom resource definitions into rds
Building Kubernetes API objects for rds
Generating deepcopy code for rds
Generating custom resource definitions for rds
Building service controller for rds
Running GO mod tidy
Generating RBAC manifests for rds
Running gofmt against generated code for rds
Updating additional GitHub repository maintenance files
==== building rds-controller release artifacts ====
Building release artifacts for rds-v1.4.20
Generating common custom resource definitions
Generating custom resource definitions for rds
Generating RBAC manifests for rds
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    @ack-bot
    ack-bot authored Jun 3, 2025
    Copy the full SHA
    26eb032 View commit details

Commits on Jun 11, 2025

  1. Update to ACK runtime v0.48.0, code-generator v0.48.0 (#227) 

    ### Update to ACK runtime `v0.48.0`, code-generator `v0.48.0`

----------

* ACK code-generator `v0.48.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.48.0)
* ACK runtime `v0.48.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.48.0)

----------

NOTE:
This PR increments the release version of service controller from `v1.4.20` to `v1.4.21`

Once this PR is merged, release `v1.4.21` will be automatically created for `rds-controller`

**Please close this PR, if you do not want the new patch release for `rds-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building rds-controller ====
Copying common custom resource definitions into rds
Building Kubernetes API objects for rds
Generating deepcopy code for rds
Generating custom resource definitions for rds
Building service controller for rds
Running GO mod tidy
Generating RBAC manifests for rds
Running gofmt against generated code for rds
Updating additional GitHub repository maintenance files
==== building rds-controller release artifacts ====
Building release artifacts for rds-v1.4.21
Generating common custom resource definitions
Generating custom resource definitions for rds
Generating RBAC manifests for rds
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    @ack-bot
    ack-bot authored Jun 11, 2025
    Copy the full SHA
    b71699b View commit details

  2. Fix PreferredBackupWindow not updating (#226) 

    Issue #, if available: [2512](aws-controllers-k8s/community#2512)

Description of changes:
- Fix type in delta check in newCustomUpdateRequestPayload()
- Add test verifying PreferredBackupkWindow is correctly included in update input
- Add .vscode to .gitignore

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    @knottnt
    knottnt authored Jun 11, 2025
    Copy the full SHA
    0bc6c82 View commit details

Commits on Jun 16, 2025

  1. Release artifacts for release v1.4.22 (#228) 

    Issue #, if available: Fixes [2512](aws-controllers-k8s/community#2512)

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
    @knottnt
    knottnt authored Jun 16, 2025
    Copy the full SHA
    1a3631a View commit details
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@
*.swp
*~
.idea
.vscode
/docs/site
bin
build
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ack_generate_info:
build_date: "2025-05-13T05:10:16Z"
build_hash: 55bf57b2806c33a7fcd074be403f26ce3f8e58db
go_version: go1.24.2
version: v0.46.2
build_date: "2025-06-13T20:37:34Z"
build_hash: e675923dfc54d8b6e09730098c3e3e1056d3c1e9
go_version: go1.24.3
version: v0.48.0
api_directory_checksum: 52968d74358773de28be65be320d1bfb9c91e0bf
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
2 changes: 1 addition & 1 deletion config/controller/kustomization.yaml
View file
Original file line number Diff line number Diff line change
@@ -6,4 +6,4 @@ kind: Kustomization
images:
- name: controller
newName: public.ecr.aws/aws-controllers-k8s/rds-controller
newTag: 1.4.18
newTag: 1.4.22
2 changes: 1 addition & 1 deletion config/controller/service.yaml
View file
Original file line number Diff line number Diff line change
@@ -11,4 +11,4 @@ spec:
port: 8080
targetPort: http
protocol: TCP
type: NodePort
type: ClusterIP
6 changes: 4 additions & 2 deletions go.mod
View file
Original file line number Diff line number Diff line change
@@ -7,14 +7,15 @@ toolchain go1.24.1
require (
github.com/aws-controllers-k8s/ec2-controller v1.1.2
github.com/aws-controllers-k8s/kms-controller v1.0.8
github.com/aws-controllers-k8s/runtime v0.46.1
github.com/aws-controllers-k8s/runtime v0.48.0
github.com/aws/aws-sdk-go v1.49.0
github.com/aws/aws-sdk-go-v2 v1.34.0
github.com/aws/aws-sdk-go-v2/service/rds v1.93.8
github.com/aws/smithy-go v1.22.2
github.com/go-logr/logr v1.4.2
github.com/samber/lo v1.37.0
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.9.0
k8s.io/api v0.32.1
k8s.io/apimachinery v0.32.1
k8s.io/client-go v0.32.1
@@ -63,6 +64,7 @@ require (
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/prometheus/client_golang v1.19.1 // indirect
github.com/prometheus/client_model v0.6.1 // indirect
github.com/prometheus/common v0.55.0 // indirect
@@ -71,7 +73,7 @@ require (
go.uber.org/multierr v1.11.0 // indirect
go.uber.org/zap v1.27.0 // indirect
golang.org/x/exp v0.0.0-20240719175910-8a7402abbf56 // indirect
golang.org/x/net v0.37.0 // indirect
golang.org/x/net v0.38.0 // indirect
golang.org/x/oauth2 v0.23.0 // indirect
golang.org/x/sync v0.12.0 // indirect
golang.org/x/sys v0.31.0 // indirect
8 changes: 4 additions & 4 deletions go.sum
View file
Original file line number Diff line number Diff line change
@@ -2,8 +2,8 @@ github.com/aws-controllers-k8s/ec2-controller v1.1.2 h1:Bry62L279S7mJofk0sS4o7T7
github.com/aws-controllers-k8s/ec2-controller v1.1.2/go.mod h1:XZOZcSk0tzplY+A0dADqD4NK4a8g8Jqwf/Ouv2Sz/eQ=
github.com/aws-controllers-k8s/kms-controller v1.0.8 h1:nDPYQhsgD2s14rEMNmGCwkm+e0Emjo/Usl3is7e9EFk=
github.com/aws-controllers-k8s/kms-controller v1.0.8/go.mod h1:HjSBjtiljNL1yFzrOizxeQe2+88tW3mHD5fnEGwVYGE=
github.com/aws-controllers-k8s/runtime v0.46.1 h1:61RU6uYiFSp0cDhv52vAmaPzrebzoudtsp1fGkk6iLk=
github.com/aws-controllers-k8s/runtime v0.46.1/go.mod h1:G2UMBKA7qgXG4JV16NTIUp715uqvUEvWaa7TG1I527U=
github.com/aws-controllers-k8s/runtime v0.48.0 h1:DnbLQ7gbhQfpOTviR+r+svLjvKhRhxRuNEZo6okZYro=
github.com/aws-controllers-k8s/runtime v0.48.0/go.mod h1:XNEBK9jN8n19dtHrprn+WlBq9wUc0RspuCmeT4nXb0s=
github.com/aws/aws-sdk-go v1.49.0 h1:g9BkW1fo9GqKfwg2+zCD+TW/D36Ux+vtfJ8guF4AYmY=
github.com/aws/aws-sdk-go v1.49.0/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
github.com/aws/aws-sdk-go-v2 v1.34.0 h1:9iyL+cjifckRGEVpRKZP3eIxVlL06Qk1Tk13vreaVQU=
@@ -177,8 +177,8 @@ golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn
golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
golang.org/x/net v0.0.0-20200226121028-0de0cce0169b/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
golang.org/x/net v0.37.0 h1:1zLorHbz+LYj7MQlSf1+2tPIIgibq2eL5xkrGk6f+2c=
golang.org/x/net v0.37.0/go.mod h1:ivrbrMbzFq5J41QOQh0siUuly180yBYtLp+CKbEaFx8=
golang.org/x/net v0.38.0 h1:vRMAPTMaeGqVhG5QyLJHqNDwecKTomGeqbnfZyKlBI8=
golang.org/x/net v0.38.0/go.mod h1:ivrbrMbzFq5J41QOQh0siUuly180yBYtLp+CKbEaFx8=
golang.org/x/oauth2 v0.23.0 h1:PbgcYx2W7i4LvjJWEbf0ngHV6qJYr86PkAV3bXdLEbs=
golang.org/x/oauth2 v0.23.0/go.mod h1:XYTD2NtWslqkgxebSiOHnXEap4TF09sJSc7H1sXbhtI=
golang.org/x/sync v0.0.0-20190423024810-112230192c58/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
4 changes: 2 additions & 2 deletions helm/Chart.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
name: rds-chart
description: A Helm chart for the ACK service controller for Amazon Relational Database Service (RDS)
version: 1.4.18
appVersion: 1.4.18
version: 1.4.22
appVersion: 1.4.22
home: https://github.com/aws-controllers-k8s/rds-controller
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
sources:
2 changes: 1 addition & 1 deletion helm/templates/NOTES.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ .Chart.Name }} has been installed.
This chart deploys "public.ecr.aws/aws-controllers-k8s/rds-controller:1.4.18".
This chart deploys "public.ecr.aws/aws-controllers-k8s/rds-controller:1.4.22".

Check its status by running:
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"
22 changes: 18 additions & 4 deletions helm/templates/caches-role-binding.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: ack-namespaces-cache-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}-namespace-caches
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
roleRef:
kind: ClusterRole
apiGroup: rbac.authorization.k8s.io
name: ack-namespaces-cache-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}-namespace-caches
subjects:
- kind: ServiceAccount
name: {{ include "ack-rds-controller.service-account.name" . }}
@@ -14,12 +21,19 @@ subjects:
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: ack-configmaps-cache-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}-configmaps-cache
namespace: {{ .Release.Namespace }}
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
roleRef:
kind: Role
apiGroup: rbac.authorization.k8s.io
name: ack-configmaps-cache-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}-configmaps-cache
subjects:
- kind: ServiceAccount
name: {{ include "ack-rds-controller.service-account.name" . }}
18 changes: 16 additions & 2 deletions helm/templates/caches-role.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: ack-namespaces-cache-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}-namespaces-cache
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
rules:
- apiGroups:
- ""
@@ -15,8 +22,15 @@ rules:
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: ack-configmaps-cache-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}-configmaps-cache
namespace: {{ .Release.Namespace }}
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
rules:
- apiGroups:
- ""
24 changes: 20 additions & 4 deletions helm/templates/cluster-role-binding.yaml
View file
Original file line number Diff line number Diff line change
@@ -2,11 +2,18 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: {{ include "ack-rds-controller.app.fullname" . }}
name: {{ include "ack-rds-controller.app.fullname" . }}-rolebinding
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
roleRef:
kind: ClusterRole
apiGroup: rbac.authorization.k8s.io
name: ack-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}
subjects:
- kind: ServiceAccount
name: {{ include "ack-rds-controller.service-account.name" . }}
@@ -17,17 +24,26 @@ subjects:
{{ $fullname := include "ack-rds-controller.app.fullname" . }}
{{ $releaseNamespace := .Release.Namespace }}
{{ $serviceAccountName := include "ack-rds-controller.service-account.name" . }}
{{ $chartVersion := include "ack-rds-controller.chart.name-version" . }}
{{ $appVersion := .Chart.AppVersion | quote }}
{{ range $namespaces }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: {{ $fullname }}
name: {{ $fullname }}-{{ . }}
namespace: {{ . }}
labels:
app.kubernetes.io/name: {{ $fullname }}
app.kubernetes.io/instance: {{ $.Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ $appVersion }}
k8s-app: {{ $fullname }}
helm.sh/chart: {{ $chartVersion }}
roleRef:
kind: Role
apiGroup: rbac.authorization.k8s.io
name: ack-rds-controller
name: {{ $fullname }}-{{ . }}
subjects:
- kind: ServiceAccount
name: {{ $serviceAccountName }}
19 changes: 17 additions & 2 deletions helm/templates/cluster-role-controller.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
{{ $labels := .Values.role.labels }}
{{ $appVersion := .Chart.AppVersion | quote }}
{{ $rbacRules := include "ack-rds-controller.rbac-rules" . }}
{{ $fullname := include "ack-rds-controller.app.fullname" . }}
{{ $chartVersion := include "ack-rds-controller.chart.name-version" . }}
{{ if eq .Values.installScope "cluster" }}
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: ack-rds-controller
name: {{ include "ack-rds-controller.app.fullname" . }}
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
{{- range $key, $value := $labels }}
{{ $key }}: {{ $value | quote }}
{{- end }}
@@ -18,9 +27,15 @@ metadata:
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: ack-rds-controller
name: {{ $fullname }}-{{ . }}
namespace: {{ . }}
labels:
app.kubernetes.io/name: {{ $fullname }}
app.kubernetes.io/instance: {{ $.Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ $appVersion }}
k8s-app: {{ $fullname }}
helm.sh/chart: {{ $chartVersion }}
{{- range $key, $value := $labels }}
{{ $key }}: {{ $value | quote }}
{{- end }}
3 changes: 3 additions & 0 deletions helm/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
@@ -204,3 +204,6 @@ spec:
{{- if .Values.deployment.extraVolumes }}
{{ toYaml .Values.deployment.extraVolumes | indent 8}}
{{- end }}
{{- with .Values.deployment.strategy }}
strategy: {{- toYaml . | nindent 4 }}
{{- end }}
11 changes: 9 additions & 2 deletions helm/templates/leader-election-role-binding.yaml
View file
Original file line number Diff line number Diff line change
@@ -2,16 +2,23 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: rds-leader-election-rolebinding
name: {{ include "ack-rds-controller.app.fullname" . }}-leaderelection
{{ if .Values.leaderElection.namespace }}
namespace: {{ .Values.leaderElection.namespace }}
{{ else }}
namespace: {{ .Release.Namespace }}
{{ end }}
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: rds-leader-election-role
name: {{ include "ack-rds-controller.app.fullname" . }}-leaderelection
subjects:
- kind: ServiceAccount
name: {{ include "ack-rds-controller.service-account.name" . }}
9 changes: 8 additions & 1 deletion helm/templates/leader-election-role.yaml
View file
Original file line number Diff line number Diff line change
@@ -2,12 +2,19 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: rds-leader-election-role
name: {{ include "ack-rds-controller.app.fullname" . }}-leaderelection
{{ if .Values.leaderElection.namespace }}
namespace: {{ .Values.leaderElection.namespace }}
{{ else }}
namespace: {{ .Release.Namespace }}
{{ end }}
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
rules:
- apiGroups:
- coordination.k8s.io
9 changes: 8 additions & 1 deletion helm/templates/role-reader.yaml
View file
Original file line number Diff line number Diff line change
@@ -3,8 +3,15 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
creationTimestamp: null
name: ack-rds-reader
name: {{ include "ack-rds-controller.app.fullname" . }}-reader
namespace: {{ .Release.Namespace }}
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
rules:
- apiGroups:
- rds.services.k8s.aws
9 changes: 8 additions & 1 deletion helm/templates/role-writer.yaml
View file
Original file line number Diff line number Diff line change
@@ -3,8 +3,15 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
creationTimestamp: null
name: ack-rds-writer
name: {{ include "ack-rds-controller.app.fullname" . }}-writer
namespace: {{ .Release.Namespace }}
labels:
app.kubernetes.io/name: {{ include "ack-rds-controller.app.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
k8s-app: {{ include "ack-rds-controller.app.name" . }}
helm.sh/chart: {{ include "ack-rds-controller.chart.name-version" . }}
rules:
- apiGroups:
- rds.services.k8s.aws
5 changes: 4 additions & 1 deletion helm/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@

image:
repository: public.ecr.aws/aws-controllers-k8s/rds-controller
tag: 1.4.18
tag: 1.4.22
pullPolicy: IfNotPresent
pullSecrets: []

@@ -41,6 +41,9 @@ deployment:
# To have DNS options set along with hostNetwork, you have to specify DNS policy
# explicitly to 'ClusterFirstWithHostNet'.
dnsPolicy: ClusterFirst
# Set rollout strategy for deployment.
# See: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy
strategy: {}
extraVolumes: []
extraVolumeMounts: []

2 changes: 1 addition & 1 deletion pkg/resource/db_cluster/custom_update.go
View file
Original file line number Diff line number Diff line change
@@ -572,7 +572,7 @@ func (rm *resourceManager) newCustomUpdateRequestPayload(
if desired.ko.Spec.Port != nil && delta.DifferentAt("Spec.Port") {
res.Port = aws.Int32(int32(*desired.ko.Spec.Port))
}
if desired.ko.Spec.PreferredBackupWindow != nil && delta.DifferentAt("Spec.PreferredBackupkWindow") {
if desired.ko.Spec.PreferredBackupWindow != nil && delta.DifferentAt("Spec.PreferredBackupWindow") {
res.PreferredBackupWindow = desired.ko.Spec.PreferredBackupWindow
}
if desired.ko.Spec.PreferredMaintenanceWindow != nil && delta.DifferentAt("Spec.PreferredMaintenanceWindow") {
Loading