Skip to content

Commit 7e46a62

Browse files
authored
fix: parameter order on tag updates (#43)
Issue [#2543](aws-controllers-k8s/community#2543) Description of changes: Fix the parameter order when updating tags, (caused panics) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent d025333 commit 7e46a62

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

apis/v1alpha1/ack-generate-metadata.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
ack_generate_info:
2-
build_date: "2025-06-25T18:55:23Z"
3-
build_hash: a488d4e8a9222ed51e5690cb5850beb21cce5a1f
4-
go_version: go1.24.3
5-
version: v0.48.0-1-ga488d4e-dirty
2+
build_date: "2025-06-27T16:02:54Z"
3+
build_hash: 7db573dd591b1dc817d9223710b6c7031d31364c
4+
go_version: go1.24.4
5+
version: v0.48.0-2-g7db573d
66
api_directory_checksum: b4eb4c1d6104667453456af5144ca269b1af8965
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.32.6

pkg/resource/secret/sdk.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/tags/sync.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ func SyncResourceTags(
4040
client tagsClient,
4141
mr metricsRecorder,
4242
resourceARN string,
43-
latestTags []*svcapitypes.Tag,
4443
desiredTags []*svcapitypes.Tag,
44+
latestTags []*svcapitypes.Tag,
4545
) error {
4646

4747
var err error

templates/hooks/secret/sdk_update_pre_build_request.go.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
if delta.DifferentAt("Spec.Tags") {
22
err := rm.syncTags(
33
ctx,
4-
latest,
54
desired,
5+
latest,
66
)
77
if err != nil {
88
return nil, err

0 commit comments

Comments
 (0)