chore: Metrics AspNetCore support #775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and middleware support for aspnetcore. Docs
boring-cyborg
bot
added
area/metrics
pull-request-size
bot
added
the
size/XXL
2 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #775 +/- ##
===========================================
+ Coverage 73.82% 73.88% +0.06%
===========================================
Files 205 209 +4
Lines 8324 8382 +58
Branches 901 905 +4
===========================================
+ Hits 6145 6193 +48
- Misses 1884 1892 +8
- Partials 295 297 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…r .NET 6.0 and 8.0
boring-cyborg
bot
added
github-actions
…a-dotnet into feature/metrics-aspnetcore
…ca/powertools-lambda-dotnet into feature/metrics-aspnetcore
… and improving syntax
… default dimensions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #773
Summary
Changes
This pull request introduces a new library for capturing and publishing custom metrics from AWS Lambda functions using ASP.NET Core. The key changes include adding project references, creating new classes for metrics handling, and updating documentation.
New Library
AWS.Lambda.Powertools.Metrics.AspNetCoreNew Library Introduction:
AWS.Lambda.Powertools.Metrics.AspNetCore: Added new project for ASP.NET Core metrics handling.AWS.Lambda.Powertools.Metrics.AspNetCore.Tests: Added new project for testing the ASP.NET Core metrics library.Metrics Handling:
Http/MetricsEndpointExtensions.cs: Added extension methods for route handlers to include metrics filters.Http/MetricsFilter.cs: Created a filter class to capture and record metrics for HTTP endpoints.Http/MetricsHelper.cs: Introduced a helper class to capture cold start metrics and record them.Http/MetricsMiddlewareExtensions.cs: Added middleware extension methods to capture metrics for HTTP requests.Documentation:
README.md: Provided detailed usage instructions and examples for the new ASP.NET Core metrics library.Solution Configuration:
AWS.Lambda.Powertools.sln: Updated the solution file to include the new ASP.NET Core metrics projects and their configurations. [1] [2]User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.