Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Metrics disabled environment variable #786

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

chore: Metrics disabled environment variable #786

wants to merge 28 commits into from

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 25, 2025

Please provide the issue number

Issue number: #781

Summary

Changes

Add POWERTOOLS_METRICS_DISABLED support to disable Metrics to be emited

User experience

Set POWERTOOLS_METRICS_DISABLED environment variable to true

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

hjgraca added 28 commits February 19, 2025 19:26
@hjgraca
feat(metrics): enhance default dimensions handling and refactor metri…
a1417ea 
…cs initialization. Adding default dimensions to cold start metrics
@hjgraca
feat(metrics): introduce MetricsOptions for configurable metrics setu…
450a2da 
…p and refactor initialization logic
@hjgraca
feat(metrics): add MetricsBuilder for fluent configuration of metrics…
df9d4fa 
… options and enhance default dimensions handling
@hjgraca
feat(metrics): enhance MetricsBuilder with detailed configuration opt…
e8ef8dd 
…ions and improve documentation
@hjgraca
feat(metrics): add ASP.NET Core metrics package with cold start track…
1690fef 
…ing and middleware support for aspnetcore.

Docs
@hjgraca
refactor(metrics): standardize parameter names for metric methods to …
1756ce1 
…improve clarity
@hjgraca
fix(metrics): ensure thread safety by locking metrics during cold sta…
e6f6be6 
…rt flag reset
@hjgraca
fix(tests): conditionally include project reference for net8.0 framework
0ecffb8
@hjgraca
feat(build): enhance CI configuration with multi-framework support fo…
a3e6a31 
…r .NET 6.0 and 8.0
@hjgraca
fix(build): update .NET setup step to use matrix variable for versioning
c1936a5
@hjgraca
fix(build): simplify dependency installation step in CI configuration
910f286
@hjgraca
fix(build): pass target framework properties during restore, build, a…
9f6f460 
…nd test steps
@hjgraca
fix(build): add SkipInvalidProjects property to build properties for …
491338e 
….NET frameworks
@hjgraca
revert to single job
60d6c64
@hjgraca
test logger
0f7c21d
@hjgraca
fix(build): update test commands and project configurations for .NET …
001dabf 
…frameworks
@hjgraca
fix(build): add /tl option to dotnet build command in build.yml
d6841ab
@hjgraca
fix(metrics): add null checks and unit tests for MetricsAspect and Me…
f8f56cf 
…tricsAttribute
@hjgraca
Merge branch 'develop' into feature/metrics-aspnetcore
abef8eb
@hjgraca
Merge branch 'develop' of https://github.com/hjgraca/powertools-lambd…
bd44564 
…a-dotnet into feature/metrics-aspnetcore
@hjgraca
Merge branch 'feature/metrics-aspnetcore' of https://github.com/hjgra…
a44ca03 
…ca/powertools-lambda-dotnet into feature/metrics-aspnetcore
@hjgraca
feat(metrics): add support for default dimensions in metrics handling
b3a57a8
@hjgraca
Merge branch 'develop' into feature/metrics-single-default-dimensions
05022f0
@hjgraca
fix functionname dimension to only coldstart
dbb3377
@hjgraca
Merge remote-tracking branch 'origin/feature/metrics-single-default-d…
34bf9d4 
…imensions' into feature/metrics-single-default-dimensions
@hjgraca
remove functionname
9e71bec
@hjgraca
feat(metrics): add function name support for metrics dimensions
97dc991
@hjgraca
feat(metrics): add support for disabling metrics via environment vari…
d02ae25 
…able
@auto-assign auto-assign bot requested review from amirkaws and sliedig February 25, 2025 11:24
@boring-cyborg boring-cyborg bot added area/common Core Powertools utility area/metrics Core metrics utility documentation Improvements or additions to documentation github-actions Changes in GitHub workflows internal Maintenance changes tests labels Feb 25, 2025
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 25, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hjgraca hjgraca linked an issue Feb 25, 2025 that may be closed by this pull request
Feature request: Metrics - environment variable to allow customer disable custom metrics #781
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirkaws amirkaws Awaiting requested review from amirkaws

@sliedig sliedig Awaiting requested review from sliedig

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/common Core Powertools utility area/metrics Core metrics utility documentation Improvements or additions to documentation github-actions Changes in GitHub workflows internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Metrics - environment variable to allow customer disable custom metrics
1 participant
@hjgraca