-
Notifications
You must be signed in to change notification settings - Fork 90
Feature enhancement: Create a Subsegments for operations handled by Powertools #1505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good idea but the idempotency module works before and after the handler method is actually executed.
|
Also, we may have a "dependency" issue. This should happen only if tracing is enabled / powertools-tracing is used. But we don't want to add a (maven) dependency to xray / powertools-tracing in the idempotency module... |
Let's do this in v2 |
Idempotency isn't the only module that calls AWS services. Do we want to add it to everything (e.g. the various params?)
This will be the trick. |
@heitorlessa wdyt? |
Is your feature request related to a problem? Please describe.
When using the idempotency module with Tracing: Active, it is not possible to see from the Trace how much time was spent inside Powertools code.
Adding a subsegment will make it easier to correlate the DynamoDB SDK calls, with the Idempotency functionality from Powertools.
Describe the solution you'd like
I would like an XRay subsegment to be created to show how long it's spent inside the Idempotency code.
This is an initial idea for discussion/consideration, it could be further expanded to other Powertools functionality.
The text was updated successfully, but these errors were encountered: