Skip to content

Commit 75989d1

Browse files
committed
fix(metrics): warn on default dimension overwrite and avoid redundant service warning
1 parent a0fdbee commit 75989d1

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

packages/metrics/src/Metrics.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -437,11 +437,6 @@ class Metrics extends Utility implements MetricsInterface {
437437
if (!this.getColdStart()) return;
438438
const singleMetric = this.singleMetric();
439439

440-
if (this.defaultDimensions.service) {
441-
singleMetric.setDefaultDimensions({
442-
service: this.defaultDimensions.service,
443-
});
444-
}
445440
const value = this.functionName?.trim() ?? functionName?.trim();
446441
if (value && value.length > 0) {
447442
singleMetric.addDimension('function_name', value);
@@ -846,9 +841,14 @@ class Metrics extends Utility implements MetricsInterface {
846841
}
847842

848843
if (Object.hasOwn(this.defaultDimensions, key)) {
849-
this.#logger.warn(
850-
`Dimension "${key}" has already been added. The previous value will be overwritten.`
851-
);
844+
const currentValue = this.defaultDimensions[key];
845+
const suppressOverwriteWarning =
846+
key === 'service' && currentValue === this.defaultServiceName;
847+
if (!suppressOverwriteWarning) {
848+
this.#logger.warn(
849+
`Dimension "${key}" has already been added. The previous value will be overwritten.`
850+
);
851+
}
852852
}
853853

854854
cleanedDimensions[key] = value;

0 commit comments

Comments
 (0)