apigw-sqs-terraform: Fix service name correctly #2790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find, @kakakakakku. I updated a few other references to HTTP. I'll add this to the publishing pipeline. |
|
Thank you so much👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Hi😀 Thanks for the useful patterns!
I tried the pattern and works good.
One thing I noticed. This pattern uses the aws_api_gateway_rest_api resource in Terraform, but the README mentions
API Gateway HTTP APIs. As you may know, Amazon API Gateway provides two types. This pattern is actually using REST APIs, not HTTP APIs.It might be better to clarify this in the README to avoid confusion.
Thank you😀
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.