Skip to content

Commit 3fc1322

Browse files
committed
fix: remove unnecessary UV build args from dev layer build
The dev layer builds FROM the base image which already has UV_INDEX_URL set as an ENV var. The uv pip install commands in the dev layer inherit that env var automatically, so passing --build-arg is redundant.
1 parent 73a18be commit 3fc1322

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/cli/operations/dev/container-dev-server.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,10 @@ export class ContainerDevServer extends DevServer {
8787
' || (pip install -q uvicorn && pip install -q /app)',
8888
].join('\n');
8989

90-
const devBuild = spawnSync(
91-
this.runtimeBinary,
92-
['build', '-t', this.imageName, '-f', '-', ...getUvBuildArgs(), this.config.directory],
93-
{
94-
input: devDockerfile,
95-
stdio: ['pipe', 'pipe', 'pipe'],
96-
}
97-
);
90+
const devBuild = spawnSync(this.runtimeBinary, ['build', '-t', this.imageName, '-f', '-', this.config.directory], {
91+
input: devDockerfile,
92+
stdio: ['pipe', 'pipe', 'pipe'],
93+
});
9894

9995
this.logBuildOutput(devBuild.stdout, devBuild.stderr, onLog);
10096

0 commit comments

Comments
 (0)