fix: disallow underscores in deployment target names and sanitize stack names (#412)

Author: notgitika

src/assets/__tests__/__snapshots__/assets.snapshot.test.ts.snap

@@ -56,8 +56,12 @@ function toEnvironment(target: AwsDeploymentTarget): Environment {
   };
 }
 
+function sanitize(name: string): string {
+  return name.replace(/_/g, '-');
+}
+
 function toStackName(projectName: string, targetName: string): string {
-  return \`AgentCore-\${projectName}-\${targetName}\`;
+  return \`AgentCore-\${sanitize(projectName)}-\${sanitize(targetName)}\`;
 }
 
 async function main() {

src/assets/cdk/bin/cdk.ts

@@ -11,8 +11,12 @@ function toEnvironment(target: AwsDeploymentTarget): Environment {
   };
 }
 
+function sanitize(name: string): string {
+  return name.replace(/_/g, '-');
+}
+
 function toStackName(projectName: string, targetName: string): string {
-  return `AgentCore-${projectName}-${targetName}`;
+  return `AgentCore-${sanitize(projectName)}-${sanitize(targetName)}`;
 }
 
 async function main() {

src/schema/schemas/__tests__/aws-targets.test.ts

@@ -73,7 +73,10 @@ describe('DeploymentTargetNameSchema', () => {
     expect(DeploymentTargetNameSchema.safeParse('default').success).toBe(true);
     expect(DeploymentTargetNameSchema.safeParse('prod').success).toBe(true);
     expect(DeploymentTargetNameSchema.safeParse('dev-us-east').success).toBe(true);
-    expect(DeploymentTargetNameSchema.safeParse('staging_env').success).toBe(true);
+  });
+
+  it('rejects name with underscores', () => {
+    expect(DeploymentTargetNameSchema.safeParse('staging_env').success).toBe(false);
   });
 
   it('rejects name starting with digit', () => {

src/schema/schemas/aws-targets.ts

@@ -27,8 +27,8 @@ export const DeploymentTargetNameSchema = z
   .min(1)
   .max(64)
   .regex(
-    /^[a-zA-Z][a-zA-Z0-9_-]*$/,
-    'Name must start with a letter and contain only alphanumeric characters, hyphens, and underscores'
+    /^[a-zA-Z][a-zA-Z0-9-]*$/,
+    'Name must start with a letter and contain only alphanumeric characters and hyphens'
   )
   .describe('Unique identifier for the deployment target');